fix i18n issue with interval names

aviral243 · Nov 15, 2017 · c508aef · c508aef
1 parent a8f6de1
commit c508aef
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/js/block.js b/js/block.js
@@ -544,10 +544,10 @@ function Block(protoblock, blocks, overrideName) {
                     this.value = getModeName(DEFAULTMODE);
                     break;
                 case 'intervalname':
-                    this.value = DEFAULTINTERVAL;
+                    this.value = getIntervalName(DEFAULTINTERVAL);
                     break;
                 case 'voicename':
-                    this.value = DEFAULTVOICE;
+                    this.value = getVoiceName(DEFAULTVOICE);
                     break;
                 case 'drumname':
                     this.value = getDrumName(DEFAULTDRUM);

diff --git a/js/logo.js b/js/logo.js
@@ -7689,7 +7689,7 @@ function Logo () {
 
         if (that.blocks.blockList[blk].name === 'intervalname') {
             if (typeof(that.blocks.blockList[blk].value) === 'string') {
-                return INTERVALVALUES[that.blocks.blockList[blk].value];
+                return getIntervalNumber(that.blocks.blockList[blk].value);
             } else {
                 return 0;
             }

diff --git a/js/musicutils.js b/js/musicutils.js
@@ -526,6 +526,20 @@ function getIntervalName(name) {
 };
 
 
+function getIntervalNumber(name) {
+    for (var interval in INTERVALNAMES) {
+        if (INTERVALNAMES[interval][0] === name) {
+	    return INTERVALVALUES[INTERVALNAMES[interval][1]];
+	} else if (INTERVALNAMES[interval][1] === name) {
+	    return INTERVALVALUES[INTERVALNAMES[interval][1]];
+	}
+    }
+
+    console.log(name + ' not found in INTERVALNAMES');
+    return 0;
+};
+
+
 function getModeName(name) {
     for (var mode in MODENAMES) {
         if (MODENAMES[mode][0] === name || MODENAMES[mode][1].toLowerCase() === name.toLowerCase()) {