Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: this.action.disposalAction is not a function #20

Open
prasannamestha opened this issue Aug 21, 2019 · 11 comments
Open

Comments

@prasannamestha
Copy link

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.40.0 x64
Electron: 3.1.10
OS: Microsoft Windows 10 Pro
Thrown From: autoclose package 0.0.2

Stack Trace

Uncaught TypeError: this.action.disposalAction is not a function

At C:\Users\Prasanna\.atom\packages\autoclose\lib\autoclose.coffee:39

TypeError: this.action.disposalAction is not a function
    at Object._paneItemChanged (/packages/autoclose/lib/autoclose.coffee:39:29)
    at /packages/autoclose/lib/autoclose.coffee:26:8
    at Function.simpleDispatch (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:1210649)
    at Workspace.didChangeActivePaneItemOnPaneContainer (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:424404)
    at WorkspaceCenter.paneContainer.onDidChangeActivePaneItem.t (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:14:44396)
    at Function.simpleDispatch (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:1209208)
    at Emitter.emit (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:1210649)
    at PaneContainer.didChangeActiveItemOnPane (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:446737)
    at Pane.setActiveItem (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:455581)
    at Pane.activateNextRecentlyUsedItem (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:456372)
    at HTMLElement.pane:show-next-recently-used-item (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:288983)
    at CommandRegistry.handleCommandEvent (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:349123)
    at KeymapManager.dispatchCommandEvent (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:1249835)
    at KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:1245969)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.40.0/resources/app/static/<embedded>:11:284329)

Commands

     -0:38.2.0 intentions:highlight (input.hidden-input)
     -0:38.1.0 pane:show-next-recently-used-item (input.hidden-input)
     -0:37.9.0 pane:move-active-item-to-top-of-stack (input.hidden-input)
     -0:37.6.0 intentions:highlight (input.hidden-input)
     -0:37.5.0 pane:show-next-recently-used-item (input.hidden-input)
     -0:37.4.0 pane:move-active-item-to-top-of-stack (input.hidden-input)
     -0:29.6.0 intentions:highlight (input.hidden-input)
     -0:29.3.0 command-palette:toggle (input.hidden-input)
     -0:25.9.0 core:move-down (input.hidden-input)
     -0:25.2.0 core:confirm (input.hidden-input)
     -0:25.2.0 settings-view:install-packages-and-themes (input.hidden-input)
     -0:16.7.0 pane:show-next-recently-used-item (button.btn.icon.enablement.icon-playback-play)
     -0:16.5.0 pane:move-active-item-to-top-of-stack (input.hidden-input)
     -0:13.2.0 intentions:highlight (input.hidden-input)
  2x -0:13 pane:show-next-recently-used-item (input.hidden-input)
     -0:12.5.0 pane:move-active-item-to-top-of-stack (input.hidden-input)

Non-Core Packages

atom-beautify 0.33.4 
atom-file-icons 0.7.1 
atom-ternjs 0.20.0 
atom-transpose 0.3.5 
atom-wrap-in-tag 0.6.0 
autoclose 0.0.2 
autocomplete-modules 2.3.0 
busy-signal 2.0.1 
change-case 0.6.5 
docblockr 0.13.7 
duplicate-line-or-selection 0.9.0 
editorconfig 2.5.0 
emmet 2.4.3 
emmet-jsx-css-modules 1.0.0 
highlight-selected 0.16.0 
hyperclick 0.1.5 
intentions 1.1.5 
js-hyperclick 1.19.0 
linter 2.3.0 
linter-eslint 8.5.5 
linter-ui-default 1.7.1 
path-copy 0.14.0 
pigments 0.40.2 
prettier-atom 0.57.2 
set-syntax 0.4.0 
sync-settings 0.8.6 
tab-foldername-index 3.3.1 
toggle-quotes 1.1.4 
tree-view-copy-relative-path 1.2.0 
@AnthonyParkinson
Copy link

Got the same

@AnthonyParkinson
Copy link

Any thoughts how to fix it?

@prasannamestha
Copy link
Author

No Idea. Haven't checked out this repository yet. Waiting for the moderators/contributors to eye on this

@Novocastrian
Copy link

I started experiencing this issue after I opened Atom with no Projects or files open, then selected File > Reopen Project > open a project from the project history here. Opening Atom with a Project folder already open does not replicate this issue.

This is using 1.40.1 for Windows 10.

@Amirneutron
Copy link

How can this be resolved ?

@RohanAdhia
Copy link

Try using this fix

4f3fe85?diff=split

resolved the issue for me!

@Novocastrian
Copy link

So, it looks like this is the same issue as #12, and the fix @RohanAdhia mentions resolves them.

@javaskript
Copy link

javaskript commented Dec 8, 2019

My changes in 4f3fe85 from over a year ago fixed this issue, but it has not been merged into master. This error is simply due to the deprecation of dispoalAction. Just open autoclose.coffee and replace @action.disposalAction() with @action.dispose().

@marinelopez619
Copy link

marinelopez619 commented Jun 7, 2020

Hello there. Check out the error code you got from your IDE..for me it was Atom. It told me

this:TypeError:
this.action.disposalAction is not a function
at Object._paneItemChanged (file:///C:/Users/Ivan Lopez/.atom/packages/autoclose/lib/autoclose.coffee:39:29)
..bla bla bla...

Copy the file path and paste it on your file explorer search bar. It should take you to the 'autoclose' file. Open it and make the changes listed below on your file's line 29 and 39. Change from:
if @action then @action.disposalAction()
to
if @action then @action.dispose()

I hope this helps!

@javaskript
Copy link

Copy the file path and paste it on your file explorer search bar. It should take you to the 'autoclose' file. Open it and make the changes listed below on your file's line 29 and 39. Change from:
if @action then @action.disposalAction()
to
if @action then @action.dispose()

I hope this helps!

This fix was mentioned multiple times in this thread already, and is already present as my commit from Oct. 2018 in 4f3fe85. OP should close this issue, as it has been solved for nearly two years.

@mshabazi68
Copy link

Thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants