You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Due to PR #492, the workflow shows a warning that docker credentials are not masked. But in the case the workflow needs them unmasked (to pass to another job for instance), you might not want to inform the users of the (reusable) workflow that they can find those credentials in the logs.
Describe the solution you'd like
Add an option show-mask-warning: true/false, default true, so one can decide to show this warning or not. If you deliberately choose to not mask credentials, then these warnings are unnecessary.
Describe alternatives you've considered
Additional context
When you have a job which has to pull a base image from ECR, you can't use the amazon-ecr-login action in the same job, hence you have to do it in a prior job and pass the docker credentials to the next job.
For example:
I think this request could be translated as I want to leave my door unlocked when I go on vacation, but I don't want a sign in my yard that tells criminals that I'm gone and they can let themselves in.
Security through obscurity is no security at all. If you want to allow users to log their credentials in plain text, at least don't make it the default behavior: #495
Is your feature request related to a problem? Please describe.
Due to PR #492, the workflow shows a warning that docker credentials are not masked. But in the case the workflow needs them unmasked (to pass to another job for instance), you might not want to inform the users of the (reusable) workflow that they can find those credentials in the logs.
Describe the solution you'd like
Add an option
show-mask-warning: true/false, default true
, so one can decide to show this warning or not. If you deliberately choose to not mask credentials, then these warnings are unnecessary.Describe alternatives you've considered
Additional context
When you have a job which has to pull a base image from ECR, you can't use the amazon-ecr-login action in the same job, hence you have to do it in a prior job and pass the docker credentials to the next job.
For example:
The text was updated successfully, but these errors were encountered: