You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After the changes in #311, the action now has the ability to download the existing task definition from AWS. However it doesn't include the existing tags on the image, and it also includes a number of unneeded properties that are returned by AWS but aren't used by the amazon-ecs-deploy-task-definition action, and their presence in the task definition generates a number of warnings.
Since these two actions are clearly intended to work together, I think that it would make sense to also include the tags in the downloaded task definition file, and to remove any unneeded properties before writing the task definition to disk.
The text was updated successfully, but these errors were encountered:
After the changes in #311, the action now has the ability to download the existing task definition from AWS. However it doesn't include the existing tags on the image, and it also includes a number of unneeded properties that are returned by AWS but aren't used by the
amazon-ecs-deploy-task-definition
action, and their presence in the task definition generates a number of warnings.Since these two actions are clearly intended to work together, I think that it would make sense to also include the tags in the downloaded task definition file, and to remove any unneeded properties before writing the task definition to disk.
The text was updated successfully, but these errors were encountered: