Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Windows flags should's cause confusion with Linux flags' name #2799

Closed
haouc opened this issue Feb 20, 2024 · 4 comments
Closed

Supported Windows flags should's cause confusion with Linux flags' name #2799

haouc opened this issue Feb 20, 2024 · 4 comments
Assignees
Labels

Comments

@haouc
Copy link
Contributor

haouc commented Feb 20, 2024

What would you like to be added:
In charts, Windows flags name are provided without definitive naming which can cause confusion for Linux users. The names should be renamed to indicate Windows.
Why is this needed:
Another dependency has renamed the Windows flags' name and now supports both names for every Windows flag, this charts can update the names accordingly to deprecate the old names.

@haouc
Copy link
Contributor Author

haouc commented Feb 20, 2024

This change should be made in https://github.com/aws/amazon-vpc-cni-k8s/blob/master/charts/aws-vpc-cni/templates/configmap.yaml#L23-L25.

The deprecation should be made after the PR in VPC resource controller is deployed to all clusters.

@haouc haouc self-assigned this Feb 20, 2024
@poblahblahblah
Copy link

Chiming in to say that these flags are confusing at best and we look forward to this being addressed!

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Apr 22, 2024
Copy link

github-actions bot commented May 7, 2024

Issue closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants