Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use Security Group Name and/or tags in Security Group Policy #20

Open
abhipth opened this issue Feb 12, 2021 · 7 comments
Open
Labels
feature request Request for a new feature

Comments

@abhipth
Copy link
Contributor

abhipth commented Feb 12, 2021

Is your feature request related to a problem? Please describe.
Security Groups are tied to VPC which means you cannot reuse Security Group Policy on clusters belonging to different VPC.

Describe the solution you'd like
SGP should allow specifying security groups using security group name and/or tags.

@abhipth abhipth added the feature request Request for a new feature label Feb 12, 2021
@abhipth abhipth changed the title Ability to use Security Group Name in Security Group Policy Ability to use Security Group Name and/or tags in Security Group Policy Feb 12, 2021
@swade1987
Copy link

This will make reviewing PRs much easier.

@jdnurmi
Copy link

jdnurmi commented Sep 28, 2022

Just to add to this, it would make using security groups defined in the EC2 ack usable - as it is, we can't reference a constructed security group automatically unless we can refer to it by name or pull it from a configMap - it'd be great if I could have a single helm chart define the security groups and the SGP instead of having to define at least one of them out-of-band or by external tooling.

@Aleksei-Poliakov
Copy link

@jdnurmi has a great point about ACK integration - something like this would be very useful not only for SecurityGroupPolicy, but also for other places that require a security group, for example ENIConfig

@GnatorX
Copy link
Contributor

GnatorX commented Mar 29, 2024

I opened a PR for this but not sure who I should engage to see where we are on supporting this feature

@jayanthvn
Copy link

@sjastis @hao for viz..

@mattbrandman
Copy link

I was literally just looking for this feature. Makes it way easier to assign when you generate the SGs automatically in terraform. Having to pick out the ID by hand is a pain and not stable if it gets destroyed

@GnatorX
Copy link
Contributor

GnatorX commented Apr 5, 2024

Hey wanted to check in since I haven't seen any update in the PR or the issue. Where are we in supporting this with the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

7 participants