Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 path should be virtual-hosted–style #8841

Open
yukikgiants opened this issue Aug 5, 2024 · 1 comment
Open

S3 path should be virtual-hosted–style #8841

yukikgiants opened this issue Aug 5, 2024 · 1 comment
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue servicecatalog

Comments

@yukikgiants
Copy link

Describe the issue

The example uses Path-style URL for the S3 object, which is not recommended and should be updated to use the Virtual-hosted-style (as documented here)

Links

https://github.com/aws/aws-cli/blob/develop/awscli/examples/servicecatalog/create-provisioning-artifact.rst?plain=1#L16

@yukikgiants yukikgiants added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Aug 5, 2024
@tim-finnigan tim-finnigan self-assigned this Aug 5, 2024
@tim-finnigan tim-finnigan added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Aug 5, 2024
@tim-finnigan
Copy link
Contributor

Thanks for reaching out — we can update the CLI examples, but first I think the ServiceCatalog needs to update their API documentation for CreateProvisioningArtifact, which references the path-style. So I think once they document virtual-style then we can reflect that in the example. I reached out to that team for review and we can revisit this.

@tim-finnigan tim-finnigan added servicecatalog p3 This is a minor priority issue and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Aug 5, 2024
@tim-finnigan tim-finnigan removed their assignment Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue servicecatalog
Projects
None yet
Development

No branches or pull requests

2 participants