Skip to content

Commit f76b245

Browse files
committed
fix: write the mms config file to a subdir os base_dir instead of /etc
fix #72
1 parent d6d75cd commit f76b245

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

src/sagemaker_inference/environment.py

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
model_dir = os.path.join(base_dir, "model") # type: str
3636
# str: the directory where models should be saved, e.g., /opt/ml/model/
3737

38+
config_dir = os.path.join(base_dir, "etc") # type: str
3839
code_dir = os.path.join(model_dir, "code") # type: str
3940
"""str: the path of the user's code directory, e.g., /opt/ml/model/code/"""
4041

src/sagemaker_inference/model_server.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@
2525

2626
import sagemaker_inference
2727
from sagemaker_inference import default_handler_service, environment, logging, utils
28-
from sagemaker_inference.environment import code_dir
28+
from sagemaker_inference.environment import code_dir, config_dir
2929

3030
logger = logging.get_logger()
3131

32-
MMS_CONFIG_FILE = os.path.join("/etc", "sagemaker-mms.properties")
32+
MMS_CONFIG_FILE = os.path.join(config_dir, "sagemaker-mms.properties")
3333
DEFAULT_HANDLER_SERVICE = default_handler_service.__name__
3434
DEFAULT_MMS_CONFIG_FILE = pkg_resources.resource_filename(
3535
sagemaker_inference.__name__, "/etc/default-mms.properties"

test/container/dummy/Dockerfile

+2-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ RUN mkdir resnet_18 \
4242

4343
COPY dummy/mms-entrypoint.py /usr/local/bin/dockerd-entrypoint.py
4444

45-
RUN mkdir -p /home/model-server/
45+
RUN mkdir -p /home/model-server/ \
46+
&& mkdir -p /opt/ml/etc
4647
COPY dummy/mme_handler_service.py /home/model-server/mme_handler_service.py
4748
ENV SAGEMAKER_HANDLER="/home/model-server/mme_handler_service.py:handle"
4849

test/container/mxnet/Dockerfile

+3-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,9 @@ WORKDIR /
107107

108108
RUN useradd -m model-server \
109109
&& mkdir -p /home/model-server/tmp \
110-
&& chown -R model-server /home/model-server
110+
&& chown -R model-server /home/model-server \
111+
&& mkdir -p /opt/ml/etc \
112+
&& chown -R model-server /opt/ml/etc
111113

112114
COPY mxnet/mms_entrypoint.py /usr/local/bin/dockerd_entrypoint.py
113115
COPY mxnet/config.properties /home/model-server

0 commit comments

Comments
 (0)