Skip to content

Commit b064aa9

Browse files
committed
update comments
1 parent a46e61b commit b064aa9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

builder/actions/setup_cross_ci_crt_environment.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
environment variables, secrets, files, etc. that is used to build up the testing environment.
1515
"""
1616

17-
# TODO: The variable is used to disable the windows certificate store test to unblock a CI failure.
18-
# The variable should be set to TRUE after the CI is fixed.
17+
# Enable windows certificate store test
1918
ENABLE_WINDOWS_CERT_STORE_TEST = True
2019

2120

builder/actions/setup_cross_ci_helpers.py

+3
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ def create_windows_cert_store(env, certificate_env, location_env):
2323
# Import the PFX into the Windows Certificate Store
2424
# (Passing '$mypwd' is required even though it is empty and our certificate has no password. It fails CI otherwise)
2525
import_pfx_arguments = [
26+
# Powershell 7.3 introduced an issue where launching powershell from cmd would not set PSModulePath correctly.
27+
# As a workaround, we set `PSModulePath` to empty so powershell would automatically reset the PSModulePath to default.
28+
# More details: https://github.com/PowerShell/PowerShell/issues/18530
2629
"$env:PSModulePath = '';",
2730
"Import-PfxCertificate",
2831
"-FilePath", pfx_cert_path,

0 commit comments

Comments
 (0)