Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gfx/gl2: use fences for resource loading instead of glFinish #158

Open
slimsag opened this issue Mar 25, 2016 · 0 comments
Open

gfx/gl2: use fences for resource loading instead of glFinish #158

slimsag opened this issue Mar 25, 2016 · 0 comments
Labels
gfx/gl2 gfx

Comments

@slimsag
Copy link
Member

slimsag commented Mar 25, 2016

glFinish causes the CPU and GPU to sync entirely, when in reality we only need the render thread to block when the resource is actually being used. We can use fences for this.
slimsag added a commit that referenced this issue Mar 25, 2016
@slimsag
gfx/gl2: fix data race in resource loading
a302f6e 
Without a `gl.Finish` operation we open up the possibility of the rendering
thread to use a texture etc that has not actually been entirely loaded by the
graphics hardware. Fix this by using a `gl.Finish` operation which sync's the
GPU and CPU entirely. This is more aggressive than we need, so #158 has been
opened to address this in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gfx/gl2 gfx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slimsag