Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create add/remove liquidity hooks #1

Open
joaobrunoah opened this issue Mar 12, 2025 · 0 comments · May be fixed by #5
Open

Create add/remove liquidity hooks #1

joaobrunoah opened this issue Mar 12, 2025 · 0 comments · May be fixed by #5
Assignees
@joaobrunoah

Comments

@joaobrunoah
Copy link
Collaborator

We should accept only Proportional Add/Remove. When it happens, we must update the virtual balances proportionally to the real balances.

We need to make sure that we round the virtual balances down on Add liquidity, and up on remove liquidity, so the BPT amount is returned correctly to the LP.
@elshan-eth elshan-eth self-assigned this Mar 12, 2025
@joaobrunoah joaobrunoah linked a pull request Mar 14, 2025 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaobrunoah joaobrunoah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust Virtual Balances when Adding/Removing liquidity balancer/reclamm
2 participants
@joaobrunoah @elshan-eth