Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement aiohttp is missing #8

Open
frafra opened this issue Mar 13, 2021 · 1 comment
Open

Requirement aiohttp is missing #8

frafra opened this issue Mar 13, 2021 · 1 comment

Comments

@frafra
Copy link

frafra commented Mar 13, 2021

>>> import httpio
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/frafra/.cache/pypoetry/virtualenvs/draft-2Uym0jAL-py3.9/lib64/python3.9/site-packages/httpio/__init__.py", line 229, in <module>
    from .asyncio import AsyncHTTPIOFileContextManagerMixin
  File "/home/frafra/.cache/pypoetry/virtualenvs/draft-2Uym0jAL-py3.9/lib64/python3.9/site-packages/httpio/asyncio.py", line 4, in <module>
    from httpio_async import AsyncHTTPIOFile, AsyncHTTPIOFileContextManagerMixin  # noqa: F401
  File "/home/frafra/.cache/pypoetry/virtualenvs/draft-2Uym0jAL-py3.9/lib64/python3.9/site-packages/httpio_async/__init__.py", line 6, in <module>
    import aiohttp
ModuleNotFoundError: No module named 'aiohttp'

httpio/setup.py

Lines 7 to 10 in 18c1b98

install_requires = [
'requests >= 2.10.0',
'six'
]

@samdbmg
Copy link

samdbmg commented Jul 28, 2021

How are you installing this? Because the version sniffing code in setup.py should add aiohttp on python >= 3.6? (A quick test in a virtualenv while doing #9 shows it seems to install for me!)

httpio/setup.py

Lines 12 to 14 in 18c1b98

if version_info[0] > 3 or (version_info[0] == 3 and version_info[1] >= 6):
packages['httpio_async'] = 'httpio_async'
install_requires.append('aiohttp >= 3.5.4')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants