Bug: crates_vendor is generating a broken defs.bzl

[redsun82]

While upgrading to 0.57.1 (or 0.57.0) we encountered a problem where crates_vendor is generating a defs.bzl where the labels are broken. For example instead of generating

"anyhow": Label("@vendor__anyhow-1.0.44//:anyhow"),

we are getting instead

"anyhow": Label("@vendor//:anyhow-1.0.44")

This then results in an error like

ERROR: no such package '@@[unknown repo 'vendor' requested from @@]//'

Initially I thought something was off with the default label template that can be provided via render_config, but I quickly found out that changing the crate_label_template there has no effect.

A reproducer can be found here (malformed content here and here). We're running bazel 8.0.0.

For the time being I'm about to work around this via this python script

import sys
import re
import pathlib

label_re = re.compile(r'"@vendor//:(.+)-([\d.]+)"')

file = pathlib.Path(sys.argv[1])
temp = file.with_suffix(f'{file.suffix}.tmp')

with open(file) as input, open(temp, "w") as output:
    for line in input:
        line = label_re.sub(lambda m: f'"@vendor__{m[1]}-{m[2]}//:{m[1].replace("-", "_")}"', line)
        output.write(line)

temp.rename(file)

[UebelAndre]

Ah, I think this is because the remote_name repository is only defined when loading the content from crates.bzl

rules_rust/crate_universe/src/rendering/templates/vendor_module.j2

Lines 1 to 32 in 09472f7

	###############################################################################
	# @generated
	# This file is auto-generated by the cargo-bazel tool.
	#
	# DO NOT MODIFY: Local changes may be replaced in future executions.
	###############################################################################
	"""Rules for defining repositories for remote `crates_vendor` repositories"""
	load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
	# buildifier: disable=bzl-visibility
	load("@rules_rust//crate_universe/private:crates_vendor.bzl", "crates_vendor_remote_repository")
	# buildifier: disable=bzl-visibility
	load("{{ crates_module_label(file="defs.bzl") }}", _crate_repositories = "crate_repositories")
	def crate_repositories():
	"""Generates repositories for vendored crates.
	Returns:
	A list of repos visible to the module through the module extension.
	"""
	maybe(
	crates_vendor_remote_repository,
	name = "{{ repository_name }}",
	build_file = Label("{{ crates_module_label(file="BUILD.bazel") }}"),
	defs_module = Label("{{ crates_module_label(file="defs.bzl") }}"),
	)
	direct_deps = [struct(repo = "{{ repository_name }}", is_dev_dep = False)]
	direct_deps.extend(_crate_repositories())
	return direct_deps

This should probably just be deleted at this point. The idea was to separate the all_crate_deps api from just accessing the URLs but the way it's currently setup is not helpful as crates.bzl loads from defs.bzl and thus you load all the wild starlark code.

Maybe in an ideal world crates.bzl would contain all the repo definitions and defs.bzl would be just the all_crate_deps interfaces but for simplicity (as there have been zero complaints about starlark analysis time) just consolidating would be good. Could I get someone to open a PR for this? It should be pretty straight forward to simply move the content of crates.bzl into defs.bzl.