Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print meaningful message if no recommended drivers are available #283

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

dennwc
Copy link
Member

@dennwc dennwc commented Apr 30, 2019

There may be cases when bblfshd cannot find any suitable drivers to be installed. It may happen mainly when bblfshd uses an old SDK version, while drivers use a new one (see #281).

PR adds a meaningful error for this case instead of exiting with no error and doing nothing.

Signed-off-by: Denys Smirnov [email protected]

@dennwc dennwc requested review from creachadair and bzz April 30, 2019 14:06
@dennwc dennwc self-assigned this Apr 30, 2019
@dennwc dennwc merged commit 4a48d66 into bblfsh:master Apr 30, 2019
@dennwc dennwc deleted the recommended branch April 30, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants