docker image cron update #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
approved these changes
Oct 4, 2019
This PR contains changes to travis and Makefile configs for periodical docker image update using travis ci cron jobs Behavior 1) if TRAVIS_EVENT_TYPE is cron then a) try to get tag using `$( git describe --exact-match "$(git rev-parse HEAD)` b) if tag is not empty run make push-drivers c) in push-drivers: if TRAVIS_EVENT_TYPE is cron pull base bblfshd image instead of rebuilding it from the scratch 2) else build as always Changes to docker tags: - timestamp is added to the version tag, so the final image will look like bblfsh/bblfshd:v2.14.0-drivers-2019-10-04 Problems: - afaik deploy will not be triggered on cron job because tags are not accessible with this event type travis-ci/travis-ci#8146 ... cannot check it on practice thus 1.a) workaround has been implemented as suggested travis-ci/travis-ci#8146 (comment) closes #309 Signed-off-by: lwsanty <[email protected]> change tag datetime to date only Signed-off-by: lwsanty <[email protected]>
lwsanty
force-pushed
the
image-cron-update
branch
from
8a4fcb3 to
e2988a9
Compare
dennwc
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to travis and Makefile configs for periodical docker image update using travis ci cron jobs
Behavior
a) try to get tag using
$( git describe --exact-match "$(git rev-parse HEAD)b) if tag is not empty run make push-drivers
c) in push-drivers: if TRAVIS_EVENT_TYPE is cron pull base bblfshd image instead of rebuilding it from the scratch
Changes to docker tags:
bblfsh/bblfshd:v2.14.0-drivers-2019-10-04Problems:
closes #309
Signed-off-by: lwsanty [email protected]
This change is