Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Add program to fixtures for performance measure #13

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

tsolakoua
Copy link
Contributor

Added the Ethiopian Multiplication C++ solution.
Related to bblfsh/bblfshd#220

Copy link
Contributor

@juanjux juanjux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tsolakoua!

@juanjux juanjux merged commit 8723745 into bblfsh:master Nov 27, 2018
@tsolakoua
Copy link
Contributor Author

@juanjux I think I also need to add the tests, right? This is the feedback I had from the Go version so I suppose I should do the same here as well.

@juanjux
Copy link
Contributor

juanjux commented Nov 27, 2018

Don't worry I'll regenerate them from the source file since I'm working on this driver right now.

@tsolakoua
Copy link
Contributor Author

thanks @juanjux ! There are 14 more cpp files that I need to upload, I suppose 1 PR with all of them would be ok.

@juanjux
Copy link
Contributor

juanjux commented Nov 27, 2018

Yes, perfectly fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants