This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Shared gRPC server config between bblfshd/driver #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzz
changed the title
3 tasks
bzz
changed the title
|
Changed to WIP as I'm looking into CI failure. |
Signed-off-by: Alexander Bezzubov <[email protected]>
bzz
force-pushed
the
refactoring/add-grpc-server-options
branch
from
4c44542 to
76b6d0b
Compare
creachadair
reviewed
Nov 21, 2018
Co-Authored-By: bzz <[email protected]>
bzz
force-pushed
the
refactoring/add-grpc-server-options
branch
from
31421c3 to
6333475
Compare
|
Removing WIP as CI is green now. Thank you for the feedback @creachadair will address the rest of it tomorrow. |
bzz
changed the title
Signed-off-by: Alexander Bezzubov <[email protected]>
Signed-off-by: Alexander Bezzubov <[email protected]>
|
Common code moved to Ready for another round. |
dennwc
suggested changes
Nov 22, 2018
Signed-off-by: Alexander Bezzubov <[email protected]>
|
All feedback addressed, @dennwc @juanjux @creachadair, it's ready for another round. |
juanjux
approved these changes
Nov 23, 2018
dennwc
approved these changes
Nov 23, 2018
creachadair
approved these changes
Nov 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the https://github.com/bblfsh/client-go/issues/102
Includes:
sdk.BuildGRPCOptionsfrom bblfshd to SDKgrpc-max-message-sizearg to all Drivers