You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice if the comparison based action alerts could be done against the commit the PR is being merged into, rather than the most recent prior commit.
#267
Open
mmcdermott opened this issue
Sep 22, 2024
· 0 comments
If I make a change in a PR and it hurts performance, I get a comment from this action alerting me. But, if I then make another change which does not resolve this performance regression, the next comparison the action does will be against the first commit in that PR, not against the base branch I'm trying to merge into, which can present a false view of my performance impact. It would be nice if the comparison could reliably be against the base of the PR rather than the most recent prior commit recorded.
The text was updated successfully, but these errors were encountered:
If I make a change in a PR and it hurts performance, I get a comment from this action alerting me. But, if I then make another change which does not resolve this performance regression, the next comparison the action does will be against the first commit in that PR, not against the base branch I'm trying to merge into, which can present a false view of my performance impact. It would be nice if the comparison could reliably be against the base of the PR rather than the most recent prior commit recorded.
The text was updated successfully, but these errors were encountered: