Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be nice if the comparison based action alerts could be done against the commit the PR is being merged into, rather than the most recent prior commit. #267

Open
mmcdermott opened this issue Sep 22, 2024 · 0 comments

Comments

@mmcdermott
Copy link

If I make a change in a PR and it hurts performance, I get a comment from this action alerting me. But, if I then make another change which does not resolve this performance regression, the next comparison the action does will be against the first commit in that PR, not against the base branch I'm trying to merge into, which can present a false view of my performance impact. It would be nice if the comparison could reliably be against the base of the PR rather than the most recent prior commit recorded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant