Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to floating UI #567

Open
benmccann opened this issue Aug 7, 2023 · 0 comments
Open

Migrate to floating UI #567

benmccann opened this issue Aug 7, 2023 · 0 comments

Comments

@benmccann
Copy link
Contributor

Floating UI is the newer version of popper. Using it will avoid all of the issues around CJS/ESM as it's properly packaged using exports

I took a bit of a stab at it, but ran out of time. I thought I'd share here as a starting point for anyone who wants to take a stab at migrating off popper.js

benmccann@46d9f94

The initial styles aren't being applied correctly in my branch, which means that the popper ends up at the bottom of the screen. I think that's the main thing to fix. I also didn't try to migrate the dropdown - though that could possibly be done in a separate PR if we don't mind having two dependencies in the interim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant