Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a warning/info message when nothing was parallelized successfully #725

Open
angelhof opened this issue Oct 12, 2024 · 2 comments
Open
Labels
good first issue! Good for newcomers

Comments

@angelhof
Copy link
Member

It might be a good idea to add a few warning/info messages to help set user expectations when running PaSh. In particular to give some intuition to the user about why they didn't get any benefits through PaSh. Some categories that I can think of which are highly relevant are:

  1. No part of the input script was parallelized. Do you have annotations for the commands in your scripts? Are you using many custom functions?
  2. The script execution was very short (<5s) to see benefits with PaSh. Maybe try running a script that takes longer?
  3. Some fragments of the input script were parallelized, but none of them took more than 1s of execution so PaSh hasn't managed to speed things up.
    We could follow up all these messages with a suggestion to use -d 1 to see more about what was parallelized and what not and get some guidance into the issues.
@angelhof angelhof added the good first issue! Good for newcomers label Oct 12, 2024
@BolunThompson
Copy link

BolunThompson commented Nov 6, 2024

Hi! I’d like to take this on. Looking through the code, I think a good way to implement this would be as a method that’s called when the compilation server is done. I can send in a PR sometime in the next few days.

@angelhof
Copy link
Member Author

angelhof commented Nov 6, 2024

Sounds great, go for it and ping me to review when you have something done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue! Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants