-
Notifications
You must be signed in to change notification settings - Fork 1
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rkday/ttlcache
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: biotz/ttlcache
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
Able to merge.
These branches can be automatically merged.
- 13 commits
- 11 files changed
- 1 contributor
Commits on Apr 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9d54fb1 - Browse repository at this point
Copy the full SHA 9d54fb1View commit details -
Upgrade project configuration and dependencies
- Upgrade to Clojure 1.10.0 - Upgrade dependencies to latest versions - Added dependencies for coding style linting - Added testing configuration - Added Clojars deployment configuration - Added Travis-CI integration configuration
Configuration menu - View commit details
-
Copy full SHA for 5c40c15 - Browse repository at this point
Copy the full SHA 5c40c15View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbee448 - Browse repository at this point
Copy the full SHA bbee448View commit details -
Configuration menu - View commit details
-
Copy full SHA for de40f67 - Browse repository at this point
Copy the full SHA de40f67View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca3348f - Browse repository at this point
Copy the full SHA ca3348fView commit details -
Fix factor values for newer versions of clojure.core.cache
Newer versions of clojure.core.cache for the TTL type use a different implementation that is way faster than it used to be. So the factors configured in the tests are no longer sensible and need to be adjusted.
Configuration menu - View commit details
-
Copy full SHA for ebdf588 - Browse repository at this point
Copy the full SHA ebdf588View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97f1e1a - Browse repository at this point
Copy the full SHA 97f1e1aView commit details -
Don't use transients for cache expiry
The library didn't expect another `clojure.core.cache` cache as it's seed value. And it tried to do things with it that it didn't support. I.e., it tried to build a transient value out of it, which `clojure.core.cache` compatible caches don't support. This is easily fixed by changing the library not to convert the cache info into a transient value. Using transients was supposed a performance optimization, but as far as we've seen, it doesn't make a noticeable difference at all.
Configuration menu - View commit details
-
Copy full SHA for 6e24bf7 - Browse repository at this point
Copy the full SHA 6e24bf7View commit details -
Make sure we completely evict entries from the cache
Entries were not evicted from the composed cache when an entry was supposed to be evicted to make room for a newly added entry. E.g., we composed an LRU cache with a 10 entries limit, with the per-item TTL cache. When we already had 10 entries in the composed cache and we wanted to add a new one, we needed to evict one of the existing entries. The issue was that after adding the new entry, if you "dumped" the contents of the cache (e.g., by using `prn`), you didn't see the entry that was supposed to have been evicted. If you called `cache/lookup` or tried to access the entry using map notation, you didn't get the entry (if you used the 3-arity versions of the functions, you were told that there was no such entry). But if you called `cache/has?` with that key, you were told that the entry *was* in the cache! (when it was supposed to *not* be there). We were not removing the entry from the expiry-heap. Which worked mostly OK when we used the cache in a stand-alone configuration, but produced the pathological behaviour described above when used in a composed cache.
Configuration menu - View commit details
-
Copy full SHA for 424e124 - Browse repository at this point
Copy the full SHA 424e124View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8c78d9 - Browse repository at this point
Copy the full SHA f8c78d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bccdca5 - Browse repository at this point
Copy the full SHA bccdca5View commit details -
All notable changes to this project will be documented in this file.
Configuration menu - View commit details
-
Copy full SHA for 159a2db - Browse repository at this point
Copy the full SHA 159a2dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fafffe9 - Browse repository at this point
Copy the full SHA fafffe9View commit details
There are no files selected for viewing