Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sample meshes for examples #1339

Merged
merged 2 commits into from
Feb 15, 2025
Merged

use sample meshes for examples #1339

merged 2 commits into from
Feb 15, 2025

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Feb 14, 2025

🚀 Pull Request

Description

This pull-request simplifies the extraction.wedge_manifold, warp.from_unstructured__lfric_orog and warp.from_unstructured__lfric_orog_eqc examples by using the convenience of the runtime generated geovista.pantry.meshes rather than loading the associated geovista.pantry.data to construct the relevant meshes.

The focus of those examples is not to highlight the capabilities of the geovista.bridge; there are several other dedicated examples that do that.

As a result, the examples have less connective tissue code to distract the reader, and also make use of the sample rather than the load sphinx-tag category.


@github-actions github-actions bot added type: examples Auto-labelled for ex/*, example/* and examples/* branches type: cache Auto-labelled labels Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (d63f59a) to head (92705f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
- Coverage   91.61%   91.61%   -0.01%     
==========================================
  Files          60       60              
  Lines        3031     3028       -3     
==========================================
- Hits         2777     2774       -3     
  Misses        254      254              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle merged commit dc2002d into main Feb 15, 2025
24 checks passed
@bjlittle bjlittle deleted the examples-use-sample-meshes branch February 15, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cache Auto-labelled type: examples Auto-labelled for ex/*, example/* and examples/* branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant