fix: unit tests

Author: blacktop

file_test.go

@@ -423,22 +423,10 @@ func TestTypeString(t *testing.T) {
 	}
 }
 
-func TestNewFatFile(t *testing.T) {
-
-	f, err := os.Open("/usr/lib/libLeaksAtExit.dylib")
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	fat, err := NewFatFile(f)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	fmt.Println(fat.Arches[0].FileTOC.String())
-
-	if fat.Arches[0].UUID().UUID.String() != "273FB269-0D2F-3A78-9874-09E004F8B069" {
-		t.Errorf("macho.UUID() = %s; want test", fat.Arches[0].UUID())
+func TestOpenBadDysymCmd(t *testing.T) {
+	_, err := openObscured("internal/testdata/gcc-amd64-darwin-exec-with-bad-dysym.base64")
+	if err == nil {
+		t.Fatal("openObscured did not fail when opening a file with an invalid dynamic symbol table command")
 	}
 }
 
@@ -644,7 +632,7 @@ func TestNewFile(t *testing.T) {
 		if t1, ok := typ.(*dwarf.StructType); ok {
 			if strings.EqualFold(t1.StructName, "thread") {
 				if !t1.Incomplete {
-					fmt.Println(t1.Defn())
+					fmt.Println(t1.Defn(false))
 				}
 			}
 		}

go.sum

@@ -1,2 +1,2 @@
-github.com/blacktop/go-dwarf v1.0.9 h1:eT/L7gt0gllvvgnRXY0MFKjNB6+jtOY5DTm2ynVX2dY=
-github.com/blacktop/go-dwarf v1.0.9/go.mod h1:4W2FKgSFYcZLDwnR7k+apv5i3nrau4NGl9N6VQ9DSTo=
+github.com/blacktop/go-dwarf v1.0.10 h1:i9zYgcIROETsNZ6V+zZn3uDH21FCG5BLLZ837GitxS0=
+github.com/blacktop/go-dwarf v1.0.10/go.mod h1:4W2FKgSFYcZLDwnR7k+apv5i3nrau4NGl9N6VQ9DSTo=

internal/obscuretestdata/obscuretestdata.go

@@ -10,10 +10,24 @@ package obscuretestdata
 import (
 	"encoding/base64"
 	"io"
-	"io/ioutil"
 	"os"
 )
 
+// Rot13 returns the rot13 encoding or decoding of its input.
+func Rot13(data []byte) []byte {
+	out := make([]byte, len(data))
+	copy(out, data)
+	for i, c := range out {
+		switch {
+		case 'A' <= c && c <= 'M' || 'a' <= c && c <= 'm':
+			out[i] = c + 13
+		case 'N' <= c && c <= 'Z' || 'n' <= c && c <= 'z':
+			out[i] = c - 13
+		}
+	}
+	return out
+}
+
 // DecodeToTempFile decodes the named file to a temporary location.
 // If successful, it returns the path of the decoded file.
 // The caller is responsible for ensuring that the temporary file is removed.
@@ -24,7 +38,7 @@ func DecodeToTempFile(name string) (path string, err error) {
 	}
 	defer f.Close()
 
-	tmp, err := ioutil.TempFile("", "obscuretestdata-decoded-")
+	tmp, err := os.CreateTemp("", "obscuretestdata-decoded-")
 	if err != nil {
 		return "", err
 	}
@@ -47,5 +61,5 @@ func ReadFile(name string) ([]byte, error) {
 		return nil, err
 	}
 	defer f.Close()
-	return ioutil.ReadAll(base64.NewDecoder(base64.StdEncoding, f))
+	return io.ReadAll(base64.NewDecoder(base64.StdEncoding, f))
 }