Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rpcHandler): onError ctx #4259

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

papsavas
Copy link
Contributor

@papsavas papsavas commented Nov 30, 2023

What are the changes and their implications?

rpcHandler now provides ctx on its Error callbacks.
For this reason, shorthands

onError: console.log

were converted to:

onError: (error, ctx) => console.log(error)

indicating ctx existence but avoiding its logging on default

Why all this?

discord convo

Feature Checklist

@papsavas papsavas requested a review from flybayer as a code owner November 30, 2023 11:20
Copy link

changeset-bot bot commented Nov 30, 2023

🦋 Changeset detected

Latest commit: f68fb89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@blitzjs/rpc Minor
next-blitz-auth Patch
@blitzjs/next Minor
@blitzjs/auth Minor
@blitzjs/codemod Minor
@blitzjs/config Minor
@blitzjs/generator Minor
blitz Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! and sorry for the late response!

.changeset/rare-squids-brake.md Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit e5cd2c8 into blitz-js:main Dec 20, 2023
30 checks passed
@blitzjs-bot
Copy link
Contributor

Added @papsavas contributions for doc and code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants