Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix<codemod-upgrade-legacy>: provide correct path to template files #4274

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

LeonMueller-OneAndOnly
Copy link
Contributor

Closes: Fixes an issue for the codemod "upgrade-legacy", where an invalid file path is used

--

Following error message is printed to the terminal:

npx @blitzjs/codemod upgrade-legacy
✖ create blitz-server.ts and blitz-client.ts setup files
Error: ENOENT: no such file or directory, open '/Users/admin/.nvm/versions/node/v16.16.0/lib/node_modules/@blitzjs/codemod/node_modules/@blitzjs/generator/dist/templates/app/app/blitz-server.ts'
This is an unexpected error. Please ask for help in the discord #general-help channel. https://discord.blitzjs.com

--

I sadly to not have the time currently to get your project up and running in order to submit a fully fleshed out pull-request, like your guidelines suggest to do.
Therefore please view this pull-request as an issue, where i want to provide the suggested solution directly.

--

Thank you for your great work on blitzJS, with best regards,
Leon Müller

Copy link

changeset-bot bot commented Jan 13, 2024

🦋 Changeset detected

Latest commit: 1f2cce6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@blitzjs/codemod Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/config Patch
@blitzjs/generator Patch
next-blitz-auth Patch
blitz Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Changes here, looks good to me! WIl do manual testing to see if any other are needed

packages/codemod/src/upgrade-legacy.ts Outdated Show resolved Hide resolved
…at collection was empty => invoke it only conditionally
@LeonMueller-OneAndOnly
Copy link
Contributor Author

Hello siddhsuresh,

I have force pushed to the forked branch in the meantime, to clean up the git history / bring in further fixes i needed to make it run on my machine (macos).

I was not aware this would influence this pull-request, I hope this does not nullify some work you did on your side. Sorry if that is the case. The 3 things I changed are really straight forward, the reason is included in each commit. I hope this helps.

With best regards,
Leon Müller

@kodiakhq kodiakhq bot merged commit 956a739 into blitz-js:main Jan 16, 2024
29 checks passed
@blitzjs-bot
Copy link
Contributor

Added @LeonMueller-OneAndOnly contributions for doc and code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants