Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate domain manager on writing #208

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Validate domain manager on writing #208

merged 3 commits into from
Oct 2, 2024

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Sep 16, 2024

Validate domain manager on writing

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The implementation is validating both the ENS Registry owner and the ERC7-721 owner to support legacy domains.

Related Issue

#203

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@pikonha pikonha added the enhancement New feature or request label Sep 16, 2024
@pikonha pikonha added this to the Database Resolver on mainnet milestone Sep 16, 2024
@pikonha pikonha self-assigned this Sep 16, 2024
@pikonha pikonha linked an issue Sep 16, 2024 that may be closed by this pull request
Validate domain manager on writing #203
Closed
@pikonha pikonha mentioned this pull request Sep 16, 2024
Closed
alextnetto
alextnetto reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@alextnetto alextnetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj!

packages/gateway/src/services/ethereumClient.ts Outdated Show resolved Hide resolved
@pikonha pikonha merged commit 9edddc4 into main Oct 2, 2024
1 check passed
@pikonha pikonha deleted the 203-validate-domain-manager-on-writing branch October 2, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduramme eduramme eduramme left review comments

@alextnetto alextnetto alextnetto left review comments

@LeonardoVieira1630 LeonardoVieira1630 Awaiting requested review from LeonardoVieira1630 LeonardoVieira1630 is a code owner

Assignees

@pikonha pikonha

Labels
enhancement New feature or request
Projects
ENS
Status: ✅ Done
Milestone
Database Resolver on mainnet
Development

Successfully merging this pull request may close these issues.

Validate domain manager on writing
3 participants
@pikonha @alextnetto @eduramme