Proposal: simplify throttled logging in the codebase

[678098]

Is there an existing proposal for this?

• I have searched the existing proposals

Is your feature request related to a problem?

Currently we have 3 ways to throttle logging:

1. With mwcu::ThrottledActionParams:

   blazingmq/src/groups/mqb/mqbblp/mqbblp_cluster.cpp

   Lines 414 to 419 in 5f65a2a

   	// Throttle error log if this is a 'failed Ack': note that we log at
   	// INFO level in order not to overwhelm the dashboard, if a queue is
   	// full, every post will nack, which could be a lot.
   	MWCU_THROTTLEDACTION_THROTTLE(
   	d_throttledFailedAckMessages,
   	BALL_LOG_INFO << description() << ": failed Ack "

2. With bdlmt::Throttle:
   

   blazingmq/src/groups/mqb/mqbs/mqbs_filestore.cpp

   Line 3669 in 5f65a2a

   if (d_alarmSoftLimiter.requestPermission()) {

3. With BALL_LOGTHROTTLE:

   blazingmq/src/groups/mqb/mqbblp/mqbblp_relayqueueengine.cpp

   Line 330 in 5f65a2a

   BALL_LOGTHROTTLE_INFO_BLOCK(k_MAX_INSTANT_MESSAGES, k_NS_PER_MESSAGE)

The good example of a problem: mqbblp::Cluster, here we have many-many fields responsible for throttled logging in the header:

blazingmq/src/groups/mqb/mqbblp/mqbblp_cluster.h

Lines 254 to 292 in 5f65a2a

	mwcu::ThrottledActionParams d_throttledFailedPutMessages;
	// Throttling parameters for failed PUT
	// messages.
	mwcu::ThrottledActionParams d_throttledSkippedPutMessages;
	// Throttling parameters for dropped
	// PUT messages.
	mwcu::ThrottledActionParams d_throttledFailedAckMessages;
	// Throttling parameters for failed ACK
	// messages.
	mwcu::ThrottledActionParams d_throttledDroppedAckMessages;
	// Throttling parameters for dropped
	// ACK messages.
	mwcu::ThrottledActionParams d_throttledFailedConfirmMessages;
	// Throttling parameters for failed
	// CONFIRM messages.
	mwcu::ThrottledActionParams d_throttledFailedRejectMessages;
	// Throttling parameters for failed
	// REJECT messages.
	mwcu::ThrottledActionParams d_throttledDroppedConfirmMessages;
	// Throttling parameters for dropped
	// CONFIRM messages.
	mwcu::ThrottledActionParams d_throttledDroppedRejectMessages;
	// Throttling parameters for dropped
	// REJECT messages.
	mwcu::ThrottledActionParams d_throttledFailedPushMessages;
	// Throttling parameters for failed
	// PUSH messages.
	mwcu::ThrottledActionParams d_throttledDroppedPushMessages;
	// Throttling parameters for dropped
	// PUSH messages.

Removing these fields by using a local BALL_LOGTHROTTLE will greatly simplify the class.

Describe the solution you'd like

Replace field-stored mwcu::ThrottledActionParams with local BALL_LOGTHROTTLE where it's possible.

Alternatives you considered

No response