Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: make AdminClient auto-closeable AbstractContextManager #198

Open
1 task done
678098 opened this issue Feb 9, 2024 · 0 comments
Open
1 task done

Refactor: make AdminClient auto-closeable AbstractContextManager #198

678098 opened this issue Feb 9, 2024 · 0 comments
Assignees
@678098
Labels
A-Testing Area: Testing enhancement New feature or request

Comments

@678098
Copy link
Collaborator

678098 commented Feb 9, 2024

Is there an existing proposal for this?

  • I have searched the existing proposals

Is your feature request related to a problem?

Currently, AdminClient is not suitable to use in with statements ensuring auto freeing of resources.

blazingmq/src/python/blazingmq/dev/it/process/admin.py

Line 16 in 6f1321d

class AdminClient:

Describe the solution you'd like

Implement AbstractContextManager interfaces in AdminClient

Alternatives you considered

No response
@678098 678098 added enhancement New feature or request A-Testing Area: Testing labels Feb 9, 2024
@678098 678098 self-assigned this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@678098 678098

Labels
A-Testing Area: Testing enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@678098