Skip to content

Commit aa4ae9e

Browse files
authored
Merge pull request #46 from bodgit/zero
Refactor to use DevZero() from plumbing
2 parents 52fde0b + 08361d5 commit aa4ae9e

File tree

4 files changed

+6
-54
lines changed

4 files changed

+6
-54
lines changed

internal/zero/reader.go

-19
This file was deleted.

internal/zero/reader_test.go

-28
This file was deleted.

part.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import (
88
"io"
99
"runtime"
1010

11+
"github.com/bodgit/plumbing"
1112
"github.com/bodgit/rvz/internal/util"
12-
"github.com/bodgit/rvz/internal/zero"
1313
"golang.org/x/sync/errgroup"
1414
)
1515

@@ -81,7 +81,7 @@ func (pr *partReader) readGroup(i int) error {
8181
var (
8282
rc io.ReadCloser
8383
err error
84-
zr = zero.NewReader()
84+
zr = plumbing.DevZero()
8585
r io.Reader
8686
)
8787

@@ -110,7 +110,7 @@ func (pr *partReader) readGroup(i int) error {
110110
_, _ = pr.h0[j].Write(h.Sum(nil))
111111
}
112112

113-
_, _ = io.CopyN(pr.h0[j], zero.NewReader(), h0Padding)
113+
_, _ = io.CopyN(pr.h0[j], plumbing.DevZero(), h0Padding)
114114
}
115115

116116
return nil
@@ -129,7 +129,7 @@ func (pr *partReader) writeHashes() {
129129
_, _ = pr.h1[i].Write(h.Sum(nil))
130130
}
131131

132-
_, _ = io.CopyN(pr.h1[i], zero.NewReader(), h1Padding)
132+
_, _ = io.CopyN(pr.h1[i], plumbing.DevZero(), h1Padding)
133133
}
134134

135135
// Calculate the H2 hashes
@@ -141,7 +141,7 @@ func (pr *partReader) writeHashes() {
141141
_, _ = pr.h2.Write(h.Sum(nil))
142142
}
143143

144-
_, _ = io.CopyN(pr.h2, zero.NewReader(), h2Padding)
144+
_, _ = io.CopyN(pr.h2, plumbing.DevZero(), h2Padding)
145145
}
146146

147147
//nolint:gochecknoglobals

reader.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"github.com/bodgit/plumbing"
1212
"github.com/bodgit/rvz/internal/packed"
1313
"github.com/bodgit/rvz/internal/util"
14-
"github.com/bodgit/rvz/internal/zero"
1514
)
1615

1716
const (
@@ -172,7 +171,7 @@ func (r *reader) groupReader(g int, offset int64, partition bool) (rc io.ReadClo
172171
return nil, nil, err
173172
}
174173
case group.size() == 0:
175-
rc = io.NopCloser(io.LimitReader(zero.NewReader(), r.disc.chunkSize(partition)))
174+
rc = io.NopCloser(io.LimitReader(plumbing.DevZero(), r.disc.chunkSize(partition)))
176175
default:
177176
rc = io.NopCloser(io.NewSectionReader(r.ra, group.offset(), group.size()))
178177
}

0 commit comments

Comments
 (0)