Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolManager forcefully aborts about to start drag interaction, causing an error #555

Open
2 tasks
nikku opened this issue Jun 22, 2021 · 0 comments
Open
2 tasks
Labels
backlog Queued in backlog bug Something isn't working

Comments

@nikku
Copy link
Member

nikku commented Jun 22, 2021

Describe the Bug

In certain, yet to figure out circumstances the ToolManager cancels an about to start drag interaction, causing the subsequent automatically activating move interaction to fail.

This leads to the drag interaction blowing up, as the drag context that is being referred to is non existing anymore:

sentry.js:2 TypeError: Cannot read property 'payload' of null
    at c (Dragging.js:183)
    at oa.init (Dragging.js:525)
    at dm.start (GlobalConnect.js:99)
    at dm.toggle (GlobalConnect.js:116)
    at Object.globalConnectTool (BpmnEditorActions.js:94)
    at Jc.Uc.trigger (EditorActions.js:170)
    at BpmnKeyboardBindings.js:135
    at EventBus.js:520
    at qt._invokeListener (EventBus.js:371)
    at qt._invokeListeners (EventBus.js:352)
    at qt.fire (EventBus.js:313)
    at Qo._keyHandler (Keyboard.js:103)
    at Qo._keydownHandler (Keyboard.js:84)
    at HTMLDocument.r (sentry.js:2)

Steps to Reproduce

A combination of click and keyboard activation causes this bug. No clear way to reproduce (yet).

Expected Behavior

  • Understand and dissect the tool manager
  • Fix it, along with the palette tool toggling (clicking subsequently should toggle the selected tool on or off

Environment

Please complete the following information:

  • Browser: Any
  • OS: Any
  • Library version: v7.x

Related to Sentry issue.

@nikku nikku added the bug Something isn't working label Jun 22, 2021
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Jun 30, 2021 — with bpmn-io-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants