Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot change literal expression name #103

Open
nikku opened this issue Nov 7, 2024 · 3 comments
Open

Cannot change literal expression name #103

nikku opened this issue Nov 7, 2024 · 3 comments
Assignees
@barmac
Labels
bug Something isn't working fixed upstream Requires integration of upstream change

Comments

@nikku
Copy link
Member

nikku commented Nov 7, 2024

Describe the Bug

When changing the name of the literal expression then the editor blows up:

capture ZzRmCW_optimized

Related to this change in dmn-js.

Steps to Reproduce

  1. Update name for literal expression from properties panel
  2. See that editor blows up

Expected Behavior

Name can successfully updated.

Environment

  • Host (Browser/Node version), if applicable: Any
  • OS: Any
  • Library version: main
@nikku nikku added the bug Something isn't working label Nov 7, 2024
This was referenced Nov 7, 2024
Merged
Merged
@nikku nikku added the ready Ready to be worked on label Nov 7, 2024 — with bpmn-io-tasks
@barmac
Copy link
Member

barmac commented Nov 8, 2024

Ouch. This is a critical bug since the error breaks the Modeler. It's present in Camunda Modeler 5.29.0

@barmac barmac self-assigned this Nov 8, 2024
@barmac
Copy link
Member

barmac commented Nov 8, 2024

This needs to be fixed in dmn-js.

@barmac barmac mentioned this issue Nov 8, 2024
Open
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac
fix: make name change behavior not break on name change
38b5c31 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684
@barmac barmac mentioned this issue Nov 8, 2024
Merged
4 tasks
@nikku nikku added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Nov 8, 2024
@nikku
Copy link
Member Author

nikku commented Nov 8, 2024

Fixed in bpmn-io/dmn-js#917.

barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac @nikku
fix: make name change behavior not break on name change
4b4fd90 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Co-authored-by: Nico Rehwaldt <[email protected]>
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac @nikku
fix: make name change behavior not break on name change
d01236b 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Co-authored-by: Nico Rehwaldt <[email protected]>
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac @nikku
fix: make name change behavior not break on name change
ce75a55 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Co-authored-by: Nico Rehwaldt <[email protected]>
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac @nikku
fix: make name change behavior not break on name change
5a5b682 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Co-authored-by: Nico Rehwaldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working fixed upstream Requires integration of upstream change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikku @barmac