Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serbian translation of the android and desktop app is very bad #35417

Closed
DavidK004 opened this issue Jan 18, 2024 · 17 comments · Fixed by brave/brave-core#27535
Closed

Serbian translation of the android and desktop app is very bad #35417

DavidK004 opened this issue Jan 18, 2024 · 17 comments · Fixed by brave/brave-core#27535
Labels
l10n OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude

Comments

@DavidK004
Copy link

Description

In the app both Cyrillic and Latin words are mixed (words written with Cyrillic alphabet and words written with Latin alphabet). In Serbian both Cyrillic and Latin alphabets are official but it is not grammatically correct to mix them.

Steps to Reproduce

  1. Switch app to Serbian
  2. Go to settings
  3. See mixed Cyrillic and Latin

Actual result:

Mixed alphabets

Expected result:

Using only either Cyrillic or Latin alphabet

Reproduces how often:

Always there

Desktop Brave version:

1.61.120 Chromium: 120.0.6099.234 (Званична верзија) (64-битни)

Android Device details:

  • Install type arm64 v8a
  • Device type Phone
  • Android version: 13

Version/Channel Information:

All channels

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

@DavidK004 DavidK004 added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 18, 2024
@GKid94
Copy link

GKid94 commented Apr 29, 2024

Same
Brave desktop 1.65.123 Chromium: 124.0.6367.91 (Official Build) (64-bit)] and Brave Android 1.64.122
Screenshot 2024-04-29 092925

@Susexe
Copy link

Susexe commented May 7, 2024

It's been this way for years. This community post from almost three years ago is a good summary of the current state.

I started considering other browsers because it bothers me and looks very unprofessional. That's why I'm willing to help improve the Serbian translation by joining the localization team. Please contact me regarding this; I already sent you a message on Transifex.

@bsclifton
Copy link
Member

cc: @AndyAnds265

@AndyAnds265
Copy link

@DavidK004, thank you for bringing this up. We are in the process of re-organizing our localization efforts. This will entail addressing multiple language related issues such as fonts and locale mapping. We will address this issue as well. I appreciate you bringing it to our attention

@Susexe
Copy link

Susexe commented Jun 5, 2024

@AndyAnds265, could you respond to my request? Aside from the issue of mixing scripts, the translation itself isn't very good. I can assist with it.

@AndyAnds265
Copy link

@Susexe - thank you for bringing this one up again. It's on my radar, in fact I was thinking about this the other day. We're not ready to work on this yet as we are migrating to a new system. Once we do, we're aiming to include the options for both Cyrillic and Latin based scripts. I cannot confirm this will be the case yet but it's what I'd like to do and plan to do.

@AndyAnds265
Copy link

@Susexe - just providing an update. We're already live with both Serbian (Latin) and Serbian (Cyrillic) options on Brave Search. Please feel free to check them out at search.brave.com.

We are working actively on the fix for the Android app and will roll out as soon as we can :)

@Susexe
Copy link

Susexe commented Aug 16, 2024

@AndyAnds265 I added a comment on the issue above.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2025

Closing as the above was fixed via brave/brave-core#27535 and merged into 1.76.x via brave/brave-core#27575. Labelled as QA/No as the above will be verified via #43444 & #39792.

@kjozwiak kjozwiak closed this as completed Feb 7, 2025
@kjozwiak kjozwiak added this to the 1.76.x - Beta milestone Feb 7, 2025
@AndyAnds265
Copy link

to add @Susexe you should see a fix for the Serbian language soon. Thank you very much for your patience.

We've also launched a Play Store experience in Serbian recently for new users: https://play.google.com/store/apps/details?id=com.brave.browser&hl=sr

@Susexe
Copy link

Susexe commented Feb 8, 2025

@AndyAnds265, thanks for your initiative!

If I understood the changes correctly, there won't be mixing of scripts any longer, which is great news. However, you default to Serbian Latin. The main script for Serbian in Chromium is Cyrillic, also Cyrillic is the official script used in Serbia. You mentioned in #39792 that you'll switch to Cyrillic as your base script for translations. Is that still the plan?

@Susexe
Copy link

Susexe commented Feb 8, 2025

I explained the perks of using Cyrillic as a base before, but it won't hurt to say it again: transliteration to Latin is 100% accurate, which would allow you to kill two birds with one stone.

@GKid94
Copy link

GKid94 commented Feb 8, 2025

Fix Cyrillic too, like Russian

@AndyAnds265
Copy link

@Susexe yes that is correct. Once this fix is rolled out we should have two distinct versions of Serbian. One will be the base, Cyrillic Serbian and the alternative Latin. They should match with Chromium options! Thank you for patience - I'm glad to hopefully have this all solved very soon.

We've also made updates on Brave Search (Brave претрага) which should be rolled out this month.

For any work we do moving forward, Cyrillic will be the base.

@AndyAnds265
Copy link

AndyAnds265 commented Feb 8, 2025

@GKid94 - I am not sure what you mean. Can you please explain further? If you are referencing the Serbian language, then it will be fixed soon.

@Susexe
Copy link

Susexe commented Feb 9, 2025

@AndyAnds265, awesome!

Do you accept volunteer contributions to your translations? I'd like to help with Serbian, considering it can be improved quite a bit.

Thanks!

@GKid94
Copy link

GKid94 commented Feb 9, 2025

@GKid94 - I am not sure what you mean. Can you please explain further? If you are referencing the Serbian language, then it will be fixed soon.

Yes, thanks 👍

@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants