Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Webcompat report dialog] Hidden "Send" button if reported URL is too long #42902

Closed
vadimstruts opened this issue Dec 14, 2024 · 2 comments · Fixed by brave/brave-core#27063
Closed

[Webcompat report dialog] Hidden "Send" button if reported URL is too long #42902

vadimstruts opened this issue Dec 14, 2024 · 2 comments · Fixed by brave/brave-core#27063
Assignees
@vadimstruts
Labels
bug needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude webcompat/reporter Bugs/features for Webcompat Reporter
Milestone
1.76.x - Beta

Comments

@vadimstruts
Copy link
Collaborator

If user tries to send Webcompat report from the site which has very long URL, the button "Send" on the Webcompat report Dialog is hidden, because of UI elements rearranging
@vadimstruts vadimstruts added OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude webcompat/reporter Bugs/features for Webcompat Reporter labels Dec 14, 2024
@vadimstruts vadimstruts self-assigned this Dec 14, 2024
@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Dec 16, 2024 •
edited
Loading

This was reported on https://x.com/aura_the_shadow/status/1867757360321900759?s=46&t=c88ZoLNNPThnGggE75IoLQ

I can't repro the issue though (on MacOS) Image

@ShivanKaul ShivanKaul added bug needs-investigation A bug not 100% confirmed/fixed labels Dec 16, 2024
@vadimstruts vadimstruts mentioned this issue Dec 18, 2024
Merged
24 tasks
@vadimstruts vadimstruts linked a pull request Dec 18, 2024 that will close this issue
[Webcompat report dialog] Hidden "Send" button if reported URL is too long brave/brave-core#27063
Merged
24 tasks
vadimstruts added a commit to brave/brave-core that referenced this issue Jan 10, 2025
@vadimstruts
[Webcompat report dialog] Hidden "Send" button if reported URL is too…
c1a3e10 
… long (#27063)

[Webcompat report dialog] Hidden "Send" button if reported URL is too long
(brave/brave-browser#42902)
---------

Signed-off-by: Vadym Struts <[email protected]>
@brave-builds brave-builds added this to the 1.76.x - Nightly milestone Jan 10, 2025
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 7, 2025 •
edited
Loading

Verification PASSED using

Brave | 1.76.52 Chromium: 133.0.6943.54 (Official Build) beta (64-bit)
-- | --
Revision | 5a91fa2d5c8a9f8d2f1bafa26281c840921fc1c2
OS | Windows 11 Version 24H2 (Build 26100.2894)

Reproduced the issue in small screen sizes (including 14" laptop screen) using STR in 1.75.175 Chromium: 133.0.6943.54 (Official Build) (64-bit)

example example
Image Image
  1. Installed 1.76.52
  2. launched Brave
  3. visited https://www.gov.uk/government/publications/public-inquiry-into-the-shootings-at-dunblane-primary-school in a new tab
  4. clicked Shields icon
  5. turned Shields DOWN for the site
  6. clicked Report site button
  7. repeated step 4 -6 for https://www.gov.uk/government/publications/apply-for-rule-6-status-on-an-enforcement-or-lawful-development-certificate-appeal/2dce425e-54bc-43f2-803b-01d185d136f8

Confirmed scrollbar shown for smaller screen sizes.

Confirmed Cancel and Submit buttons are visible and able to submit a report

2025-02-07_10h42_37.mp4

@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimstruts vadimstruts

Labels
bug needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude webcompat/reporter Bugs/features for Webcompat Reporter
Projects
None yet
Milestone
1.76.x - Beta
Development

Successfully merging a pull request may close this issue.

[Webcompat report dialog] Hidden "Send" button if reported URL is too long brave/brave-core
4 participants
@ShivanKaul @brave-builds @MadhaviSeelam @vadimstruts