From fa1f5081ab51dbc614a3220833d48dcd8ec1d6dc Mon Sep 17 00:00:00 2001
From: Miguel Covarrubias <mcovarr@broadinstitute.org>
Date: Thu, 6 Feb 2025 17:00:18 -0500
Subject: [PATCH] v4 all the GitHub action things [VS-1573]

---
 .../upload-gatk-test-results/action.yml       |  2 +-
 .github/workflows/gatk-nightly-docker.yml     |  2 +-
 .github/workflows/gatk-tests.yml              | 26 +++++++++----------
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/.github/actions/upload-gatk-test-results/action.yml b/.github/actions/upload-gatk-test-results/action.yml
index b210216d2f0..a84a2d5830a 100644
--- a/.github/actions/upload-gatk-test-results/action.yml
+++ b/.github/actions/upload-gatk-test-results/action.yml
@@ -34,7 +34,7 @@ runs:
   steps:
     - name: Upload test results
       if: always()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         # ternary expression syntax is workaround found here https://github.com/actions/runner/issues/409
         name: test-results-${{ inputs.is-docker == 'true' && 'docker-' ||  '' }}${{ matrix.Java }}-${{ matrix.testType }}
diff --git a/.github/workflows/gatk-nightly-docker.yml b/.github/workflows/gatk-nightly-docker.yml
index 8978ec0067e..a9ef91a1067 100644
--- a/.github/workflows/gatk-nightly-docker.yml
+++ b/.github/workflows/gatk-nightly-docker.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout gatk
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
diff --git a/.github/workflows/gatk-tests.yml b/.github/workflows/gatk-tests.yml
index 2f97d560b65..fa8af796cb0 100644
--- a/.github/workflows/gatk-tests.yml
+++ b/.github/workflows/gatk-tests.yml
@@ -40,7 +40,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout gatk
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - uses: ./.github/actions/purge-runner-disk
 
@@ -64,7 +64,7 @@ jobs:
           outputs: type=docker,dest=/tmp/myimage.tar
       # By uploading the docker image as an artifact we save ourselves the requirement for the image to be built with ghcr push permission
       - name: Upload docker image as artifact 
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: gatkDockerImage
           path: /tmp/myimage.tar
@@ -86,12 +86,12 @@ jobs:
       SCALA_VERSION: ${{ matrix.scalaVersion }}
     name: Java ${{ matrix.Java }} build and test ${{ matrix.testType }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: ./.github/actions/purge-runner-disk
       - name: 'Set up java ${{ matrix.Java }}'
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           java-version: ${{ matrix.Java }}
           distribution: 'temurin'
@@ -160,14 +160,14 @@ jobs:
 
     name: Java ${{ matrix.Java }} test on docker ${{matrix.testType}}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0 #TODO make this shallow
 
       - uses: ./.github/actions/purge-runner-disk
 
       - name: 'Set up java ${{ matrix.Java }}'
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           java-version: ${{ matrix.Java }}
           distribution: 'temurin'
@@ -204,7 +204,7 @@ jobs:
           cp scripts/docker/dockertest.gradle .
 
       - name: Download docker image artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: gatkDockerImage
           path: /tmp
@@ -252,12 +252,12 @@ jobs:
     runs-on: ubuntu-latest
     name: Validate script WDLs using womtools
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: ./.github/actions/purge-runner-disk
       - name: Set up java 17
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           java-version: '17'
           distribution: 'temurin'
@@ -273,12 +273,12 @@ jobs:
     runs-on: ubuntu-latest
     name: Validate generated WDLs using womtools
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: ./.github/actions/purge-runner-disk
       - name: Set up java 17
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           java-version: '17'
           distribution: 'temurin'
@@ -299,14 +299,14 @@ jobs:
     continue-on-error: true
     name: WDL test ${{ matrix.wdlTest }} on cromwell
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - uses: ./.github/actions/purge-runner-disk
       - name: pull lfs files
         run: git lfs pull
       - name: Set up java 17
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           java-version: '17'
           distribution: 'temurin'