Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check verifier's password when checkoff #57

Closed
julienfortin opened this issue Jul 18, 2015 · 4 comments
Closed

Check verifier's password when checkoff #57

julienfortin opened this issue Jul 18, 2015 · 4 comments
Assignees

Comments

@julienfortin
Copy link
Contributor

Make sure that the password of the verifier is checked when checkoff.

@julienfortin julienfortin self-assigned this Jul 26, 2015
@julienfortin
Copy link
Contributor Author

Done, I am about to commit the code

@mitar
Copy link
Member

mitar commented Aug 1, 2015

Hm, what exactly is this? Is this that even if you are signed in, you have to still enter the password? Like it is in the current workshift website?

I think this is not a good UX. Imagine that on the mobile device you have to enter your password every time you want to sign off.

What I would do is instead have this be a simple sign-off as it was before, and then have a special "quick sign-off" page where user does not have to be logged in at all to sign off people. So then we would have that page open in the kitchen. That one takes username, password, and who to sign off and this is it.

But if you log in into the system, then you are in and you do not have to reenter passwords again.

What do you think?

(I am reopening this to discuss.)

@mitar mitar reopened this Aug 1, 2015
@julienfortin
Copy link
Contributor Author

I think that the title plus the description are pretty accurate to explain the issue. On the original version you could checkoff workshift without asking a verifier (without using the verifier password to confirm the checkoff).

Now only the verifier (not the work shifter) has to enter his password.

Making a sign off page is a new issue, it's even a "feature" since it wasn't design this way on this workshift website.

I hope this make sense

@julienfortin
Copy link
Contributor Author

The discussion should continue there: #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants