messy solution - 15 Files Changed

Author: btihen

app/apis/currency_helper.rb

@@ -3,7 +3,7 @@
 class CurrencyHelper
   class << self
     def find_currency(user)
-      case user.person.address.country
+      case user.person.address.on(Date.today).country
       when 'CH'
         'CHF'
       when 'DE'

app/controllers/accounting_controller.rb

@@ -2,14 +2,16 @@
 
 class AccountingController < ApplicationController
   def show(*)
-    holdings = Security.joins(user: { person: :address })
-                       .group('addresses.country', 'securities.ticker')
-                       .sum('securities.quantity')
+    holdings =
+      Security.joins(user: { person: { address: :address_versions } })
+              .group('address_versions.country', 'securities.ticker')
+              .sum('securities.quantity')
 
     evaluated_holdings = holdings.map do |(country, ticker), quantity|
       fee_dollar = StockApi.get_share_price(ticker, Date.today) * quantity * Constants::FEE_RATE
 
-      user = Address.find_by(country:).person.user
+      address_version = AddressVersion.on_date(Date.today).where(country:).first
+      user = address_version.address.person.user
       currency = CurrencyHelper.find_currency(user)
       rate = CurrencyExchangeApi.find_conversion_rate('USD', currency, Date.today)
       fee_currency = fee_dollar * rate

app/controllers/login_controller.rb

@@ -16,9 +16,15 @@ def login(email:, password:)
   end
 
   def signup(email:, password:, passcode:, name:, street:, zip:, city:, country:) # rubocop:disable Metrics/ParameterLists
-    address = Address.new(street:, city:, zip:, country:)
-    person = Person.new(name:, address:)
-    @user  = User.new(email:, password:, person:)
+    # address = Address.create
+    # address.address_versions.create(
+    #   street:, city:, zip:, country:, valid_from: Time.now
+    # )
+    # person = Person.create(address:)
+    # person.name_versions.create(name:, valid_from: Time.now)
+
+    # @user = User.new(email:, password:, person:)
+    @user = build_user(email:, password:, name:, street:, zip:, city:, country:) # rubocop:disable Metrics/LineLength
 
     if passcode.present?
       passcode = Passcode.find_by(name:, street:, zip:, city:, country:, passcode: passcode.to_i)
@@ -42,6 +48,17 @@ def show_profile(user_id:)
 
   private
 
+  def build_user(email:, password:, name:, street:, zip:, city:, country:) # rubocop:disable Metrics/ParameterLists
+    address = Address.create
+    address.address_versions.create(
+      street:, city:, zip:, country:, valid_from: Date.today
+    )
+    person = Person.create(address:)
+    person.name_versions.create(name:, valid_from: Date.today)
+
+    User.new(email:, password:, person:)
+  end
+
   def redirect(_user)
     if @user.admin?
       redirect_to(AdminController, user_id: @user.id)

app/controllers/profile_controller.rb

@@ -10,20 +10,19 @@ def show(user_id:)
   def change_name_to(user_id:, name:, valid_from:)
     @user = User.find(user_id)
 
-    @user.person.name = name
-    @user.save
+    NameVersion.create(
+      person_id: @user.person.id, name:, valid_from:
+    )
 
     render(ProfileView)
   end
 
   def change_address_to(user_id:, street:, zip:, city:, country:, valid_from:)
     @user = User.find(user_id)
-
-    @user.person.address.street = street
-    @user.person.address.zip = zip
-    @user.person.address.city = city
-    @user.person.address.country = country
-    @user.save
+    AddressVersion.create(
+      address_id: @user.person.address.id,
+      street:, zip:, city:, country:, valid_from:
+    )
 
     render(ProfileView)
   end

app/models/address.rb

@@ -2,4 +2,13 @@
 
 class Address < ActiveRecord::Base
   has_one :person
+  has_many :address_versions
+
+  def last
+    address_versions.order(valid_from: :desc).first
+  end
+
+  def on(date = Date.today)
+    address_versions.where('valid_from <= ?', date).order(valid_from: :desc).first
+  end
 end

app/models/address_version.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class AddressVersion < ActiveRecord::Base
+  belongs_to :address
+
+  scope :on_date, lambda { |date|
+    where('valid_from <= ?', date)
+      .order(valid_from: :desc)
+      .limit(1)
+  }
+end

app/models/name_version.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class NameVersion < ActiveRecord::Base
+  belongs_to :person
+end

app/models/person.rb

@@ -3,4 +3,23 @@
 class Person < ActiveRecord::Base
   belongs_to :address, autosave: true
   has_one :user
+  has_many :name_versions
+
+  def version_dates
+    (
+      name_versions.map(&:valid_from) +
+      address.address_versions.map(&:valid_from)
+    ).sort.uniq
+  end
+
+  def name
+    name_versions.order(valid_from: :desc)
+                 .first&.name
+  end
+
+  def name_on(date = Date.today)
+    name_versions.where('valid_from <= ?', date)
+                 .order(valid_from: :desc)
+                 .first&.name
+  end
 end

app/views/admin_view.rb

@@ -6,7 +6,16 @@ def title = 'Administrator dashboard'
 
   def content
     @users.select { _1.person.present? }.map do |user|
-      "#{user.email}, #{user.person.name}, #{user.person.address.street}, #{user.person.address.zip} #{user.person.address.city}, #{user.person.address.country}"
+      person = user.person
+      version_dates = person.version_dates
+      (
+        ["#{user.email}:"] +
+        version_dates.map do |date|
+          name = person.name_on(date)
+          address = person.address.on(date)
+          "  #{name}, #{address.street}, #{address.zip} #{address.city}, #{address.country}"
+        end
+      ).join("\n")
     end.join("\n")
   end
 

app/views/investment_fees_view.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class InvestmentFeesView < View
-  def title = "#{@user.person.name}'s fees (in #{currency})"
+  def title = "#{@user.person.name_on(Date.today)}'s fees (in #{currency})"
 
   def content
     if @fees.positive?

app/views/investment_news_view.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class InvestmentNewsView < View
-  def title = "#{@user.person.name}'s news"
+  def title = "#{@user.person.name_on(Date.today)}'s news"
 
   def content = @news
 end

app/views/portfolio_view.rb

@@ -7,9 +7,9 @@ def title = "#{@user.person.name}'s portfolio"
   def content
     currency = CurrencyHelper.find_currency(@user)
     if @portfolio_value.positive?
-      "#{@user.person.name}, your portfolio is worth #{format('%.2f', @portfolio_value)} #{currency}"
+      "#{@user.person.name_on(Date.today)}, your portfolio is worth #{format('%.2f', @portfolio_value)} #{currency}"
     else
-      "#{@user.person.name}, your portfolio is worth nothing"
+      "#{@user.person.name_on(Date.today)}, your portfolio is worth nothing"
     end
   end
 

app/views/profile_view.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
 class ProfileView < View
-  def title = "#{@user.person.name}'s profile"
+  def title = "#{@user.person.name_on(Date.today)}'s profile"
 
   def content
     person = @user.person
-    address = person.address
+    address = person.address.on(Date.today)
     <<~PROFILE
-      Name: #{person.name}
+      Name: #{person.name_on(Date.today)}
       EMail: #{@user.email}
       Address: #{address.street}, #{address.zip} #{address.city}
       Country: #{address.country}

db/migrate/20231014080533_create_versions.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+class CreateVersions < ActiveRecord::Migration[7.0]
+  def change
+    create_table :address_versions do |t|
+      t.references :address, null: false, foreign_key: true
+      t.string :street
+      t.string :city
+      t.string :zip
+      t.string :country
+      t.date :valid_from, null: false
+
+      t.timestamps
+    end
+
+    create_table :name_versions do |t|
+      t.references :person, null: false, foreign_key: true
+      t.string :name
+      t.date :valid_from, null: false
+
+      t.timestamps
+    end
+
+    remove_column :people, :name, :string
+
+    remove_column :addresses, :street, :string
+    remove_column :addresses, :city, :string
+    remove_column :addresses, :zip, :string
+    remove_column :addresses, :country, :string
+  end
+end

db/schema.rb

@@ -10,12 +10,29 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2023_09_15_080533) do
+ActiveRecord::Schema[7.0].define(version: 2023_10_14_080533) do
+  create_table "address_versions", force: :cascade do |t|
+    t.integer "address_id", null: false
+    t.string "street"
+    t.string "city"
+    t.string "zip"
+    t.string "country"
+    t.date "valid_from", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["address_id"], name: "index_address_versions_on_address_id"
+  end
+
   create_table "addresses", force: :cascade do |t|
-    t.string "street", null: false
-    t.string "city", null: false
-    t.string "zip", null: false
-    t.string "country", null: false
+  end
+
+  create_table "name_versions", force: :cascade do |t|
+    t.integer "person_id", null: false
+    t.string "name"
+    t.date "valid_from", null: false
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["person_id"], name: "index_name_versions_on_person_id"
   end
 
   create_table "passcodes", force: :cascade do |t|
@@ -28,7 +45,6 @@
   end
 
   create_table "people", force: :cascade do |t|
-    t.string "name", null: false
     t.integer "address_id", null: false
     t.index ["address_id"], name: "index_people_on_address_id"
   end
@@ -48,6 +64,8 @@
     t.index ["person_id"], name: "index_users_on_person_id"
   end
 
+  add_foreign_key "address_versions", "addresses"
+  add_foreign_key "name_versions", "people"
   add_foreign_key "people", "addresses"
   add_foreign_key "securities", "users"
   add_foreign_key "users", "people"