Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC #0105] pack should support build image extension with Docker #1623

Closed
natalieparellano opened this issue Feb 6, 2023 · 8 comments · May be fixed by #1791
Closed

[RFC #0105] pack should support build image extension with Docker #1623

natalieparellano opened this issue Feb 6, 2023 · 8 comments · May be fixed by #1791
Labels
status/in-progress Issue or PR that is currently in progress. type/enhancement Issue that requests a new feature or improvement.

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Feb 6, 2023

RFC: https://github.com/buildpacks/rfcs/blob/main/text/0105-dockerfiles.md

Description

pack enables build image extension by calling the extender. However, this is sub-optimal. While enabling users to play with the feature, it is not performant, using kaniko under the hood.

Proposed solution

As pack already has access to a daemon, it can apply the dockerfiles directly, saving the extended build base image in the daemon. Thus it will not need to use the extender.

Additional context

In the build image case, having this feature will allow us to drop the requirement that the image being extended is published to a registry (because we are not using kaniko, we don't need a manifest).

Acceptance criteria

pack build with image extensions should complete N ms faster compared to pack build with image extensions now.

@natalieparellano natalieparellano added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. labels Feb 6, 2023
@cubxxw
Copy link
Contributor

cubxxw commented Mar 6, 2023

I want to implement this function. How should I prepare? Are there any detailed reference steps?

@natalieparellano natalieparellano added status/blocked Issue or PR that is blocked. See comments. and removed status/triage Issue or PR that requires contributor attention. labels Mar 6, 2023
@natalieparellano
Copy link
Member Author

@cubxxw thank you for your interest! This issue is actually intended for the Google Summer of Code mentorship project (I've marked it blocked for now). If you're just interested in getting involved with pack, I'd suggest checking out one of our "good first issues". Or, if you are interested in applying to GSoC, here is some additional background about this issue that might be helpful:

Dockerfiles in the CNB spec is a relatively new and rather niche feature, but it unlocks a lot of use cases. Some prior knowledge of buildpacks will be useful in the implementation. See the tutorial here: https://buildpacks.io/docs/extension-author-guide/create-extension/ and the RFC here: https://github.com/buildpacks/rfcs/blob/main/text/0105-dockerfiles.md

@samyakjain10
Copy link

Hey @natalieparellano, I am Samyak Jain, a final year student pursuing B.Tech in Mathematics and Computing from Delhi Technological University. I find this project really interesting for GSOC'23. Could you help me out in getting started?

@Nandini99-git
Copy link

Hey @natalieparellano , I am Nandini, a second year student pursuing B.E in Information and Technology and I am interested in this project for GSOC 2023. I want to work on this. I am familiar with the technology that is required for this project.

@y-ykcir
Copy link

y-ykcir commented Mar 15, 2023

Hi @natalieparellano, I am a master from Zhejiang University, familiar with cloud native, kubernetes, docker and Go, I am also interested in this project and hope to participate in the community through this issue.

@riticksingh
Copy link

Hi @natalieparellano , currently I am doing my research on cloud securtiy (specifically for conatainer security) , let me know if I can use my skill in contributing this issue.

for now I am going through the https://github.com/buildpacks/rfcs/blob/main/text/0105-dockerfiles.md
Please share if something else requires to be done beforehand

@ihanwen99
Copy link

ihanwen99 commented Mar 30, 2023

Dear team @natalieparellano , I am a master student from Shanghai Jiao Tong Unversity and TUM. I have great interests in this project. Do you still accept student to apply GSoC with this project? Should we solve the good first issue and then we can apply? Thank you very much.

@natalieparellano natalieparellano changed the title [RFC #0105] pack should support build/run image extension with Docker [RFC #0105] pack should support build image extension with Docker Aug 3, 2023
@natalieparellano natalieparellano added status/in-progress Issue or PR that is currently in progress. and removed status/blocked Issue or PR that is blocked. See comments. labels Aug 18, 2023
@natalieparellano natalieparellano added this to the 0.31.0 milestone Aug 18, 2023
@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Oct 17, 2023
@jjbustamante jjbustamante modified the milestones: 0.33.0, 0.34.0 Nov 15, 2023
@jjbustamante jjbustamante removed this from the 0.34.0 milestone Mar 8, 2024
@natalieparellano
Copy link
Member Author

Closing this issue as our findings from #1791 showed that the added complexity from this change may not be worth the performance benefit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/in-progress Issue or PR that is currently in progress. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants