-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support docker://
URIs for builder lifecycle parameter
#2076
Labels
good first issue
A good first issue to get started with.
help wanted
Need some extra hands to get this done.
status/ready
Issue ready to be worked on.
type/enhancement
Issue that requests a new feature or improvement.
Comments
braunsonm
added
status/triage
Issue or PR that requires contributor attention.
type/enhancement
Issue that requests a new feature or improvement.
labels
Feb 20, 2024
braunsonm
changed the title
Support
Support Feb 20, 2024
docker://
URIs for lifecycle parameterdocker://
URIs for builder lifecycle parameter
jjbustamante
added
status/ready
Issue ready to be worked on.
good first issue
A good first issue to get started with.
and removed
status/triage
Issue or PR that requires contributor attention.
labels
Feb 21, 2024
Hey @jjbustamante, I want to give it a try. Could you please assign this to me? |
Hi @jjbustamante , I would like to take a look if this is available |
@prashantrewar were you still working on this one, or could @rashadism have it? |
@natalieparellano, I apologize, I'm busy with something. @rashadism you can feel free to try it. Thank you! |
2 tasks
@jjbustamante @natalieparellano Hi can u review the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
A good first issue to get started with.
help wanted
Need some extra hands to get this done.
status/ready
Issue ready to be worked on.
type/enhancement
Issue that requests a new feature or improvement.
Description
Right now we can provide a
docker://
URI for the buildpacks listed in a builder inside thebuilder.toml
but we cannot do the same thing with thelifecycle
.Proposed solution
Describe alternatives you've considered
Right now you need to provide a link to the tar.gz and cannot use docker images.
Additional context
The reason this would be a great quality of life feature is primarily because almost all the other fields in the specification allow
docker://
archives. This would be consistent and not require a separate location for storage of the lifecycle binaries. It is a bit inconsistent that at build time you are able to specify a custom lifecycle image, but you can't do the same when you are packaging a builder.The text was updated successfully, but these errors were encountered: