-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dialogs to Radix #3470
Comments
From what I can tell, it seems impossible for us to keep the same structure as before where dialogs can be used like this: <PreviewDialog v-if="open" /> We'd have to move to controlling the There's three alternatives here: 1. Move all component logic into an "inner" component, e.g.
|
Looking into this again, it might be unwise to roll our own modals here but I'm not sure there's any other choice. Radix (React) has their components split into individual packages including their internal components, we don't have this for Radix Vue, so we'd need to patch the We should keep the dialog component generic enough so that we can reuse it for the search dialog, which right now is the only thing that isn't making use of our design system's Dialog component. Bluesky went for this approach for their web-based dialogs, so we know that it works well. We'd just have to watch out for breaking changes that might happen as a result, as they are, internal components. |
Bad news: Radix Vue is bundled, I'm not sure if there's any good way of doing this then |
No description provided.
The text was updated successfully, but these errors were encountered: