Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MutationObserver #43

Open
byteface opened this issue Nov 16, 2021 · 2 comments
Open

MutationObserver #43

byteface opened this issue Nov 16, 2021 · 2 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed up-for-grabs https://up-for-grabs.net/#/

Comments

@byteface
Copy link
Owner

While answering a question on stackoverflow today i realised that domonics mutationobserver is still commented out as TODO but also querySelectorAll is supposed to be 'not live'...

https://stackoverflow.com/questions/69975232/track-changes-within-dom-element-with-mutationobserver-python/69987634?noredirect=1#comment123721040_69987634

I have a feeling ours will be live. so should be returning node copies instead? It may not be and passing by value so I'll have to check.

If anyone is keen to dev this bit up then take it away. Otherwise will leave as a ticket for now til i get time.

@byteface byteface added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed up-for-grabs https://up-for-grabs.net/#/ labels Nov 16, 2021
@7HR4IZ3
Copy link

7HR4IZ3 commented Feb 5, 2024

Already implemented this in my fork, I'll submit a PR soon..

@byteface
Copy link
Owner Author

byteface commented Feb 7, 2024

Hi @7HR4IZ3 thanks for this. I had a quick look but didn't see any unit tests and I've been a little busy lately so will check soon as possible. I'm really grateful for the work. I know it was a big chunk of work so am grateful if you've managed to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed up-for-grabs https://up-for-grabs.net/#/
Projects
None yet
Development

No branches or pull requests

2 participants