Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce issues #21

Open
ineiti opened this issue Mar 5, 2024 · 0 comments
Open

Nonce issues #21

ineiti opened this issue Mar 5, 2024 · 0 comments

Comments

@ineiti
Copy link
Member

ineiti commented Mar 5, 2024

The use of nonces is not optimal for the moment:

  • the pool-client in core/txn/pool/controller/action.go just increases the nonce by 1 every time Sync is called. Instead it should request the current nonce from the blockchain
  • the transaction check in core/validation/simple/simple.go allows for some leeway in Service.Accept, whereas the Service.validateTx only allows correct nonces. IIUC, the validateTx should also accept the same leeway, else it will not work. Even better, the system should not need the leeway. I'm not sure if it actually orders transactions so that the nonces are correct. Probably it just discards wrong nonces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant