Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JobCard] Make Fields Editable #79

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

alliu879
Copy link
Collaborator

@alliu879 alliu879 commented Apr 8, 2023

What's new in this PR

Description

  • Add a form to allow users to edit the field values of a job card
  • Conditionally render input fields rather than text when editing
  • Create new jobState state within JobCard and set the state when job edits are saved

Screenshots

Screen Shot 2023-04-07 at 6 02 04 PM
Screen Shot 2023-04-07 at 6 02 28 PM
Screen Shot 2023-04-07 at 6 03 45 PM
Screen Shot 2023-04-07 at 6 04 00 PM

How to review

  • Click "Edit" to start editing and ensure that edited fields are properly updated when saved
  • Ensure that any discarded changes do not appear in the job card

Next steps

  • Ensure that editing access is only available to admins
  • Add scroll to job cards in order to properly be able to save edits to longer jobs
  • Replace "Edit" button with editing icon (i.e. pencil) and make styling changes based on Mia's designs (coming soon)
  • Refactor code to remove hard-coded values for job field names (i.e. date, contactPerson, etc.). Blocked by PR Use Firestore Listener to Update Feed and Approval Screens #78

Relevant Links

Online sources

Related PRs

CC: @surajr10 @themiachou8

@alliu879 alliu879 requested a review from surajr10 April 8, 2023 01:08
@alliu879 alliu879 changed the title Make job cards editable Make Job Cards Editable Apr 8, 2023
@alliu879 alliu879 changed the title Make Job Cards Editable [Job Card] Make Fields Editable Apr 9, 2023
@alliu879 alliu879 changed the title [Job Card] Make Fields Editable [JobCard] Make Fields Editable Apr 9, 2023
@alliu879 alliu879 force-pushed the albert/editable-job-fields branch from a73b7fb to 16278cf Compare April 27, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant