Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support modifying the sizes array after bricks is instantiated #43

Open
mikefayer opened this issue Jun 24, 2017 · 1 comment
Open

Support modifying the sizes array after bricks is instantiated #43

mikefayer opened this issue Jun 24, 2017 · 1 comment

Comments

@mikefayer
Copy link

In my use case, the sizes array is calculated dynamically based on the state of the parent layout (the layout holding the bricks.js instance.) It's possible for the parent layout to change dynamically, which would require recalculating the sizes array.

The most direct solution would be to supply a new sizes array to an existing bricks.js instance and then repack. Do you think this is worth a PR?

I also considered tearing down the existing bricks.js instance and rebuilding it, but I'm not sure if that's the best way to go because of the overhead, and because tearing it down cleanly doesn't seem straightforward. Would you say that this is the preferred approach? Thanks!

@yairopro
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants