You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently do two kinds of environment configuration
AWS-oriented, in database.py. Possible values are Dev, Staging, and Prod
Testing-oriented, in tests. Basically a boolean for whether to inject test data.
I think this could be one big thing. That's how it's handled in more traditional all-in-one backend frameworks (eg Rails) -- you'd have dev (for local dev)/test (for local test data)/staging/prod. I also think we could abstract it slightly, maybe it doesn't explicitly need to be for just AWS.
This might entail some name changes for our current lambda functions, which use dev for something like a temp or sandbox env. It might be very annoying to do this, so maybe we could just tack on local_dev for now.
Use case
The GA4GH service info spec includes a place to include an environment name, which is what got me thinking about this. They recommend dev, staging, and prod but emphasize that it's up to the implementer
I think it'd be nice to unify these settings for other simplicity reasons
I think it'd be nice to make them a little more consistent with how other people (e.g. new hires, potential external devs) might expect them to be named
Acceptance Criteria
Collapse checks in tests for GENE_TEST and all uses of AwsEnvName into a single enum
It should still be possible to run tests against a local DB and against a DB populated with test data
There's some confirmation requirements for running in certain environments, we should think about how to retain those smartly
Consider changing env name values where necessary
Proposed solution
No response
Alternatives considered
No response
Implementation details
No response
Potential Impact
No response
Additional context
No response
Contribution
Yes, I can create a PR for this feature.
The text was updated successfully, but these errors were encountered:
Feature description
We currently do two kinds of environment configuration
database.py
. Possible values areDev
,Staging
, andProd
I think this could be one big thing. That's how it's handled in more traditional all-in-one backend frameworks (eg Rails) -- you'd have
dev
(for local dev)/test
(for local test data)/staging
/prod
. I also think we could abstract it slightly, maybe it doesn't explicitly need to be for just AWS.dev
for something like atemp
orsandbox
env. It might be very annoying to do this, so maybe we could just tack onlocal_dev
for now.Use case
dev
,staging
, andprod
but emphasize that it's up to the implementerAcceptance Criteria
GENE_TEST
and all uses ofAwsEnvName
into a single enumProposed solution
No response
Alternatives considered
No response
Implementation details
No response
Potential Impact
No response
Additional context
No response
Contribution
Yes, I can create a PR for this feature.
The text was updated successfully, but these errors were encountered: