Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Dismiss ToolbarBatchActions Overlay #2102

Open
dsamerotte opened this issue Feb 25, 2025 · 3 comments
Open

Cannot Dismiss ToolbarBatchActions Overlay #2102

dsamerotte opened this issue Feb 25, 2025 · 3 comments

Comments

@dsamerotte
Copy link

We're porting an existing project to Svelte 5 and the latest versions throughout (e.g., carbon-components-svelte 0.82.4 ⇒ 0.87.6 and @sveltejs/kit 2.17.2) but are running up against an issue with ToolbarBatchActions. Specifically, once the batch action toolbar overlay becomes active, it cannot be dismissed, neither by clearing selected rows, nor by using the cancel button.

We reproduced the issue by creating a new SvelteKit project (npx sv create my-app), adding carbon-components-svelte/icons, importing css (all), creating two test routes with blank +page.svelte pages, and pasting the two ToolbarBatchActions examples from the docs into each, "Batch selection with batch actions toolbar" and "Batch selection with controlled toolbar." (The latter example overwrites the default cancel behavior.) Neither works, failing in the same manner as in our project.

We suspect this might be a Svelte 5 issue and see the, possibly related, #2033; however, we haven't had a chance to dig in further than that. We also haven't found any other potentially relevant bugs or release notes.

Let us know if you need any additional information. Thanks!

@metonym
Copy link
Collaborator

metonym commented Feb 25, 2025

I was able to repro the bug with DataTable with batch actions toolbar with Svelte version 5.20.3 and above.

Can you also confirm if you are on 5.20.3 or above? Can you try 5.20.2 and see if you can still repro the issue?

@metonym
Copy link
Collaborator

metonym commented Feb 25, 2025

I've recorded an upstream Svelte bug report: sveltejs/svelte#15386

@dsamerotte
Copy link
Author

Yes, we had updated to 5.20.4, and dropping down to 5.20.2 fixes the issue. We're now tracking the upstream bug. Thanks for the quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants