Remove and fix JSON tests for cardano Tx

The hard-coded JSON test is not applicable anymore and the expected
schema for ToJSON Tx is now RawTransaction.

Author: ch1bo

hydra-node/test/Hydra/Ledger/CardanoSpec.hs

@@ -30,7 +30,7 @@ import Hydra.Ledger.Cardano (
  )
 import Test.Aeson.GenericSpecs (roundtripAndGoldenSpecs)
 import Test.Cardano.Ledger.Babbage.Arbitrary ()
-import Test.QuickCheck (Property, checkCoverage, conjoin, counterexample, cover, forAll, forAllBlind, property, sized, vectorOf, (.&&.), (===))
+import Test.QuickCheck (Property, checkCoverage, conjoin, counterexample, cover, forAll, forAllBlind, property, sized, vectorOf, withMaxSuccess, (.&&.), (===))
 import Test.QuickCheck.Property (expectFailure)
 import Test.Util (propCollisionResistant)
 
@@ -71,20 +71,9 @@ spec =
       prop "Roundtrip CBOR encoding" $ roundtripCBOR @Tx
 
       prop "JSON encoding of Tx according to schema" $
-        prop_validateJSONSchema @Tx "api.json" $
-          key "components" . key "schemas" . key "Transaction"
-
-      -- TODO(SN): rather ensure we use the right (cardano-api's) witness format as a test
-      it "parses a specific Tx" $ do
-        let bs =
-              "{\"witnesses\":\
-              \    {\"keys\": [\"825820db995fe25169d141cab9bbba92baa01f9f2e1ece7df4cb2ac05190f37fcc1f9d58400599ccd0028389216631446cf0f9a4b095bbed03c25537595aa5a2e107e3704a55050c4ee5198a0aa9fc88007791ef9f3847cd96f3cb9a430d1c2d81c817480c\"]\
-              \    },\
-              \ \"body\":{\"outputs\":[{\"address\":\"addr1vx35vu6aqmdw6uuc34gkpdymrpsd3lsuh6ffq6d9vja0s6spkenss\",\"value\":{\"lovelace\":14}}],\
-              \           \"inputs\":[\"9fdc525c20bc00d9dfa9d14904b65e01910c0dfe3bb39865523c1e20eaeb0903#0\"]\
-              \          }\
-              \ }"
-        shouldParseJSONAs @Tx bs
+        withMaxSuccess 5 $
+          prop_validateJSONSchema @Tx "api.json" $
+            key "components" . key "schemas" . key "RawTransaction"
 
     describe "applyTransactions" $ do
       prop "works with valid transaction" appliesValidTransaction
@@ -108,7 +97,7 @@ spec =
         it "produces realistic values" $
           forAll genValue propRealisticValue
 
-shouldParseJSONAs :: forall a. FromJSON a => LByteString -> Expectation
+shouldParseJSONAs :: forall a. (HasCallStack, FromJSON a) => LByteString -> Expectation
 shouldParseJSONAs bs =
   case Aeson.eitherDecode bs of
     Left err -> failure err