-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop custom prelude #1801
Comments
This was an ADR back in the day. Feel free to propose superseding this using your arguments: https://hydra.family/head-protocol/adr/8 |
I'm tempted to agree with this proposal; I also really dislike the custom prelude, and I agree that things like I also agree that it would help onboarding and just general code navigation. One bonus feature I would request, if we make this change, is to start using PackageImports, which helps a great deal. Some open questions I wonder about:
If you can write up these in an ADR similar to the one linked by @ch1bo then I think we can evaluate and see what everyone thinks. Thanks for starting this conversation! |
I would like to enable
-Wmissing-import-lists
globally across the project, but this is unreasonable to do so while we use a custom prelude. Custom preludes (or just re-exports in general) are an impedance to forensics, and to onboarding. It places a high expectation on contributors to learn a new set of defaults when the alternatives are already very widely known. More code is read than written, and it does not save any significant effort, for example, to writewriteFileBS
rather thanBS.writeFile
, especially when the latter is already common practice and, given the shortcut is undiscoverable via hoogle, is likely to simply result in corrections in the pull request. I propose to simply delete the prelude, and just use the normal prelude and normal imports, so that we can enable the missing import list warnings.The text was updated successfully, but these errors were encountered: