Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use retry logic when kapp deploy encounters client connection lost #762

Open
idoru opened this issue Jun 7, 2023 · 1 comment
Open

Use retry logic when kapp deploy encounters client connection lost #762

idoru opened this issue Jun 7, 2023 · 1 comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.

Comments

@idoru
Copy link

idoru commented Jun 7, 2023

Describe the problem/challenge you have
kapp deploy fails without retry on http2: client connection lost

Example from our CI environment which uses kapp deploy:

	    | 3:45:49PM: ---- waiting on 6 changes [61/67 done] ----
3:46:49PM: Deploy failed 
	    | E0607 15:46:48.669366      32 request.go:1058] Unexpected error when reading response body: http2: client connection lost
	    | kapp: Error: waiting on reconcile packageinstall/bitnami-services (packaging.carvel.dev/v1alpha1) namespace: tap-install:
	    |   Errored:
	    |     Getting resource packageinstall/bitnami-services (packaging.carvel.dev/v1alpha1) namespace: tap-install:
	    |       API server says: unexpected error when reading response body. Please retry. Original error: http2: client connection lost (reason: )
	    | Deploying: Error (see .status.usefulErrorMessage for details)

Describe the solution you'd like
Use retry logic when this sort of network error is encountered.

Anything else you would like to add:
N/A


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@idoru idoru added carvel triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Jun 7, 2023
@praveenrewar praveenrewar added carvel accepted This issue should be considered for future work and that the triage process has been completed priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. and removed carvel triage This issue has not yet been reviewed for validity labels Jun 19, 2023
@100mik
Copy link
Contributor

100mik commented Jun 19, 2023

We do have a set of errors we retry for, this would qualify as an addition if we are sure that we won't risk retrying in cases which we cannot recover from while matching to this error string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.
Projects
Status: Unprioritized
Development

No branches or pull requests

3 participants