Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change module name #869

Closed
wants to merge 1 commit into from
Closed

Conversation

YashPimple
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #854

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Signed-off-by: Yash Pimple <[email protected]>
@prashantrewar
Copy link
Contributor

hey @YashPimple, could you try running ./hack/build.sh

@@ -15,7 +15,7 @@ require (
github.com/spf13/cobra v1.7.0
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.8.4
github.com/vmware-tanzu/carvel-kapp-controller v0.46.2
carvel.dev/kapp/kapp-controller v0.46.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YashPimple can you please check this path is not correct.

@praveenrewar
Copy link
Member

Superseded by #927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use vanity urls to change the go module name
4 participants