Add filter for apps for which ownership can be overriden #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100mik
force-pushed
the
filtered-ownership-override
branch
7 times, most recently
from
bf6bc86
to
24a56f5
Compare
praveenrewar
approved these changes
Aug 5, 2024
|
Some options I had thought of, |
100mik
force-pushed
the
filtered-ownership-override
branch
from
24a56f5
to
e69f420
Compare
|
From a convo offline, we are going with |
100mik
force-pushed
the
filtered-ownership-override
branch
from
e69f420
to
594af4f
Compare
Signed-off-by: Soumik Majumder <[email protected]>
Signed-off-by: Soumik Majumder <[email protected]>
100mik
force-pushed
the
filtered-ownership-override
branch
from
594af4f
to
7a62e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces a flag which allows users to specify flags which apps ownership can be snatched from while allowing ownership overrides.
Which issue(s) this PR fixes:
Fixes #993
Additional Notes for your reviewer:
The only catch today, is that it is a best effort listing of apps, limited to the namespace the new app itself is being deployed in. This is in line with encouraged kapp-controller patterns.
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: